404716 - AIX Compilation error for trunk build source xptcstubs_ppc_aix64.cpp : "nsIInterfaceInfo" did not find a declaration , "CallMethod" is not a member of "class nsXPTCStubBase"

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071025 Firefox/2.0.0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071025 Firefox/trunk build

While compiling trunk build on AIX, getting below compilation error - 

/AIX_5.2_Clobber/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_aix64.cpp", line 58.5: 1540
-0274 (S) The name lookup for "nsIInterfaceInfo" did not find a declaration.
/AIX_5.2_Clobber/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_aix64.cpp", line 58.23: 154
0-0274 (S) The name lookup for "iface_info" did not find a declaration.
/AIX_5.2_Clobber/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_aix64.cpp", line 188.18: 15
40-0217 (S) "CallMethod" is not a member of "class nsXPTCStubBase".

With the trunk build, the class nsXPTCStubBase definition is moved from the file xptcall.h to xptcprivate.h. Also the class definition for nsXPTCStubBase has got changed and the below previous member functions are not existing anymore in xptcprivate.h. 
 
    NS_IMETHOD GetInterfaceInfo(nsIInterfaceInfo** info) = 0;
    NS_IMETHOD CallMethod(PRUint16 methodIndex,
                          const nsXPTMethodInfo* info,
                          nsXPTCMiniVariant* params) = 0;

This is causing a compilation error while compiling the source code 'xptcstubs_ppc_aix64.cpp' as it calls the previous memebr functions 'GetInterfaceInfo' and 'CallMethod'

       

Reproducible: Always

Steps to Reproduce:
1.Build Mozilla Firefox Trunk build on AIX with Gnome 2.12 RPMS of 64 bit version.
2.
3.
Actual Results:  
Build fails with the above errors.

Expected Results:  
No build failure

Comment 1

[Benjamin Smedberg]

AIX needs OS-specific changes from bug 349002.

Comment 2

[Shailen]

Attachment: Patch V1

Created a patch to fix the compiler errors on AIX

Comment 3

[Reed Loden [:reed]]

Comment on attachment 291641 [details] [diff] [review]
Patch V1

Don't forget to request review on patches. :)

Comment 4

[Damon Sicore (:damons)]

Comment on attachment 291641 [details] [diff] [review]
Patch V1

a=endgame drivers

Comment 5

[Reed Loden [:reed]]

Thanks for the patch.

Checking in xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_ppc_aix.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_ppc_aix.s,v  <--  xptcinvoke_asm_ppc_aix.s
new revision: 1.9; previous revision: 1.8
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_ppc_aix64.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_ppc_aix64.s,v  <--  xptcinvoke_asm_ppc_aix64.s
new revision: 1.2; previous revision: 1.1
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_ppc_ibmobj_aix.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_ppc_ibmobj_aix.s,v  <--  xptcinvoke_asm_ppc_ibmobj_aix.s
new revision: 1.3; previous revision: 1.2
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_aix.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_aix.cpp,v  <--  xptcstubs_ppc_aix.cpp
new revision: 1.9; previous revision: 1.8
done
Checking in xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_aix64.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_ppc_aix64.cpp,v  <--  xptcstubs_ppc_aix64.cpp
new revision: 1.2; previous revision: 1.1
done