404771 - Native GTK treeview expander arrows

Status: RESOLVED INCOMPLETE

(Core :: Widget: Gtk, defect)

Description

[Michael Monreal [:micmon]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112105 Minefield/3.0b2pre

Playing with places, I found the Treeview folder expanders to have a strange feel. Compared to native GTK, the arrows are slightly bigger and don't give feedback on mouse-over.

Are those arrows drawn using GTK? If yes, it would be nice if thei could be fixed a bit. If not, can they be drawn natively? ;) Even if they cannot be drawn natively, it would be nice to have a workaround (CSS should make this possible) to at least change on mouse over.

Reproducible: Always

Comment 1

[Michael Monreal [:micmon]]

Attachment: Screenshot

This shows the look in FF3 and native GTK (Nautilus), both normal and mouse-over states.

Comment 2

[Michael Ventnor]

We cannot give hover feedback due to technical reasons in another part of the codebase that I'm not familiar in. To tell you the truth none of the widgets are "native", we have to draw them ourselves as boxes from the theme.

Comment 3

[Michael Monreal [:micmon]]

Ah yes, I should really write "native" instead of just native. ;)

Hmm, I expected this not to be too difficult but it's more like a "nice to have" feature. It does give some user feedback, but it's not the most important thing Firefox 3 needs.

Still thanks a lot for investigating this far.

Comment 4

[Julien "_FrnchFrgg_" RIVAUD]

The size part of the bug is WFM, can we change this bug to be about hover feedback on native themed treeview expander arrows ? (and confirm this bug)

Comment 6

[Julien "_FrnchFrgg_" RIVAUD]

Treeview expander arrows should also be animated.

In bug 412957, Michael said:

> This can't be fixed with the current infrastructure of XUL trees because
>
> a) There is no support of intermediate states or animations
> b) A frame is not constructed for each expander (I assume for perf reasons) so
> it is impossible to get the hover state of each individual expander, we will
> instead get the hover state of the actual treeview.
>
> So unless the code for trees undergoes an overhaul, this is unlikely to be
> fixed for Firefox 3.

Leaving it open for eventual future work.

Comment 7

[u294409]

We can leave animation alone since other apps like Pidgin in his buddy list doesn't have animation for expander too.

But the hover and the sizes... We need to fix them.

Comment 9

[Michael Monreal [:micmon]]

No longer relevant with Photon theme.