Closed Bug 404834 Opened 17 years ago Closed 17 years ago

Menuitem for show/hide Search Bar is broken

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mozilla, Assigned: Fallen)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.9) Gecko/20071025 Firefox/2.0.0.9
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.10pre) Gecko/20071121 Calendar/0.8pre

'View - Search Bar' is broken: You can't toggle the Unifinder's Search Bar anymore. It's id has changed from "searchBox" to "unifinder-searchBox", but the command doesn't reflect this yet.

Reproducible: Always

Steps to Reproduce:
1. Try to hide the Search Bar by unchecking it in 'View - Search Bar'.
2.
3.
Actual Results:  
Nothing happens.

Expected Results:  
The Search Bar should disappear.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.10pre) Gecko/20071122 Calendar/0.8pre
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch Fix v1Splinter Review
Takes care. The top border looks a bit strange when the searchbox is not shown, but I think it was this way before we changed the unifinder and I'm not sure about how this looks in lightning.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #289858 - Flags: review?(michael.buettner)
Component: Sunbird Only → General
OS: Windows XP → All
QA Contact: sunbird → general
Hardware: PC → All
Comment on attachment 289858 [details] [diff] [review]
Fix v1

r=mickey.
Attachment #289858 - Flags: review?(michael.buettner) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11pre) Gecko/20071201 Calendar/0.8pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.