404943 - [10.5] Bounce the download folder in the Dock when downloads finish

Status: RESOLVED FIXED

(Camino Graveyard :: General, enhancement)

Description

[Mihai]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.9) Gecko/20071025 Camino/1.5.3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.9) Gecko/20071025 Camino/1.5.3

Please add the following enhancement to Camino, that models the behavior in Apple applications (Safari, Mail):

when a download finishes bounce the downloads stack icon in the dock once.

Reproducible: Always

Steps to Reproduce:
1.Download something in the browser
2.I usually set the downloads window to automatically close
Actual Results:  
The Downloads stack in the dock does not indicate that download has finished.

Expected Results:  
If Camino download folder is set to X and folder X is in the dock, bounce the X icon once.
Usually X is Downloads folder in user home dir.

I'm not sure if this is Leopard specific, but I guess it can be implemented in Tiger also.

Comment 1

[Chris Lawson (gone)]

Not for 10.4 since other  Apple apps don't do it there either.

Comment 2

[Stuart Morgan]

Is there an API/notification for doing this?

Comment 3

[Chris Lawson (gone)]

Mihai, do you know an answer to comment 2?

Comment 4

[Chris Lawson (gone)]

Heh. Someone went to the trouble of writing all this up recently:

http://web.me.com/oddysseey/A_Hard_Days_Programming/A_Hard_Days_Programming/Entries/2008/11/2_Make_those_folders_bounce.html

In case that disappears before someone implements this, we need to send the "com.apple.DownloadFileFinished" notification via the NSDistributedNotificationCenter and pass the path to the downloaded file as the object of the notification.

Is there any reason *not* to do this?

Comment 5

[Stuart Morgan]

Nope.

Comment 6

[Ilya Sherman]

Attachment: Patch

Comment 7

[Chris Lawson (gone)]

Comment on attachment 352170 [details] [diff] [review]
Patch

Patch applies, builds, and works great. Yay for p-safari!

Two nits:

>+// Notification name to make the Downloads dock icon bounce.

This isn't a complete sentence, so it doesn't need caps and a period. Alternatively, make it a complete sentence and keep the caps and period.

>+static NSString* const DockDownloadFinishedNotificationName = @"com.apple.DownloadFileFinished";

I'm not crazy about the constant's name, but I can't think of anything much better at the moment. (Maybe just drop the "Dock" prefix?)

r=me with the first nit addressed, and maybe Stuart has some suggestions on the constant name.

Comment 8

[Chris Lawson (gone)]

On second thought, how about losing the comment on the const declaration and moving it to the part where you actually send the notification (and make it explain why you're sending that, since it's not at *all* obvious from the code what result that would have).

cl

Comment 9

[Stuart Morgan]

Comment on attachment 352170 [details] [diff] [review]
Patch

>+static NSString* const DockDownloadFinishedNotificationName = @"com.apple.DownloadFileFinished";

How about DownloadFinishedOSNotificationName?

>+    

Remove whitespace

>+    if (!mUserCancelled && !mDownloadFailed) {
>+      [[NSDistributedNotificationCenter defaultCenter]
>+       postNotificationName:DockDownloadFinishedNotificationName object:mDestPath];
>+    }

Definitely put a comment like "Bounce the folder in the Dock" before this block.

sr=smorgan with those changes.

Comment 10

[Ilya Sherman]

Attachment: Patch v2, nits addressed

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

Thanks for the work, and congrats on your first patch to land!