405024 - "cookie" window not updated when a cookie is deleted

Status: NEW

(Firefox :: Settings UI, enhancement)

Description

[Jesus Cea]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.10pre) Gecko/20071121 BonEcho/2.0.0.10pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.10pre) Gecko/20071121 BonEcho/2.0.0.10pre

Open "show cookies" window. Put in the filter the domain of a server sending cookies. For example, for autentication.

Delete the relevant cookies in the "cookies" window.



Reproducible: Always

Steps to Reproduce:
1. Open "show cookies" window. Put in the filter the domain of a server sending cookies. For example, for autentication.
2. Delete the relevant cookies in the "cookies" window. keep the window open and visible.
3. Go to the site and sign in.
4. You will be the cookie creation "in real time" in the "cookie" window.
5. Now, do "logout". 
Actual Results:  
The cookie is deleted, but the "cookie" window is not updated in real time. Close the "cookie" window and reopen it. Search for that cookie. It is not there, since your are logged out.

Expected Results:  
The "cookie" window should be updated in real time, just like cookie addition. I guess that if a cookie is expired, the "cookie" window should be updated also!.

Comment 1

[Jesus Cea]

This issue is present in Firefox 2 and 3.

Comment 2

[Jesus Cea]

if you do several login/logout cycles, the "cookies" window will show several cookies "outdated", since it is updated when a new cookie arrives, but not when a cookie is deleted.

Comment 3

[Simon Lieschke]

Attachment: a page that helps testing this issue

I came across this issue today with a workmate.

The attached file, when accessed over HTTP, can be used to easily reproduce this problem. It contains a link that will let you continually add and remove the same cookie from the same page rather than needing to perform login/logout cycles.

Comment 4

[Danny Sadinoff]

The relevant line of code appears to be here:

http://hg.mozilla.org/mozilla-central/annotate/e455909e2a17/browser/components/preferences/cookies.js#129

The author writes in the midst of handling various callbacks from the CookieManager, 
    // We don't yet handle aData == "deleted" - it's a less common case
    // and is rather complicated as selection tracking is difficult

Note that the "reload" callback is handled properly, rebuilding the whole list from scratch.  This might be considered a reasonable fallback for the "deleted" cookie case, but the author (goodger?) appears to have felt that the stability of the selection was more valuable than maintaining the integrity of the list.  

There is a certain logic to this position. 
I would disagree, but I don't have commit rights :)

I suggest a patch to do the same thing on "delete" as "reload", while the correct, stable delete-handler waits for creation.  I'll try to put one together.

Comment 5

[Tyler Downer [He/Him]]

This bug was originally reported on Firefox 2.x or older, which is no longer supported and will not be receiving any more updates. I strongly suggest that you update to Firefox 3.6.6 or later, update your plugins (flash, adobe, etc.), and retest in a new profile. If you still see the issue with the updated Firefox, please post here. Otherwise, please close as RESOLVED > WORKSFORME
http://www.mozilla.com
http://support.mozilla.com/kb/Managing+profiles
http://support.mozilla.com/kb/Safe+mode

Comment 6

[Danny Sadinoff]

Retested in FF 3.6.6 in safe mode.  Bug is still there, and my patch is still pending :)

Comment 7

[Wayne Mery (:wsmwk)]

Reporter, can you still reproduce using a current version?
If no, please set status to RESOLVED and resolution to WORKSFORME.
If yes, please provide updated information.

Comment 8

[Phoenix]

Still reproducible, btw, suppose Preferences will be more appropriate section