405185 - Talos fails on 10.5/Leopard: user does not exist

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Schroepfer]

Attachment: Patch to make talos run fine on 10.5

It looks like the arguments to ps have changed which causes the GetProcessData function in cmanger_mac.py to fail on 10.5.  This function uses:

ps -Acup+pid (e.g. ps -Acup303)

If you run this in the terminal you'll get "ps: No user named 'p303'.  This causes Talos to hang when it hits this spot.  The semantics of -u has changed betwen 10.4 and 10.5 it seems.

Simple fix is to tell ps what you want it to print
'ps -o pid,vsize,rss -p+pid'

Which also simplifies the parsing.

Tried this on 10.4 and works great there as well.  Patch attached.

Comment 1

[Mike Schroepfer]

Attachment: Patch to make talos run fine on 10.5

Comment 2

[Mike Schroepfer]

Comment on attachment 289993 [details] [diff] [review]
Patch to make talos run fine on 10.5

First attachment was wrong - this one should do the trick.

I know Talos isn't meant for 10.5 right away - but this may make it easier for folks doing stand-alone testing.

Comment 3

[Rob Campbell [:rc] (:robcee)]

looks good to me.

Comment 4

[alice nodelman [:alice] [:anode]]

Comment on attachment 289993 [details] [diff] [review]
Patch to make talos run fine on 10.5

Looks good to me too.

Comment 5

[alice nodelman [:alice] [:anode]]

Checking in cmanager_mac.py;
/cvsroot/mozilla/testing/performance/talos/cmanager_mac.py,v  <--  cmanager_mac.py
new revision: 1.2; previous revision: 1.1
done

Comment 6

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.