Talos fails on 10.5/Leopard: user does not exist

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
5 years ago

People

(Reporter: mtschrep, Assigned: mtschrep)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Created attachment 289992 [details] [diff] [review]
Patch to make talos run fine on 10.5

It looks like the arguments to ps have changed which causes the GetProcessData function in cmanger_mac.py to fail on 10.5.  This function uses:

ps -Acup+pid (e.g. ps -Acup303)

If you run this in the terminal you'll get "ps: No user named 'p303'.  This causes Talos to hang when it hits this spot.  The semantics of -u has changed betwen 10.4 and 10.5 it seems.

Simple fix is to tell ps what you want it to print
'ps -o pid,vsize,rss -p+pid'

Which also simplifies the parsing.

Tried this on 10.4 and works great there as well.  Patch attached.
Attachment #289992 - Flags: review?(anodelman)
(Assignee)

Comment 1

11 years ago
Created attachment 289993 [details] [diff] [review]
Patch to make talos run fine on 10.5
Attachment #289992 - Attachment is obsolete: true
Attachment #289992 - Flags: review?(anodelman)
(Assignee)

Comment 2

11 years ago
Comment on attachment 289993 [details] [diff] [review]
Patch to make talos run fine on 10.5

First attachment was wrong - this one should do the trick.

I know Talos isn't meant for 10.5 right away - but this may make it easier for folks doing stand-alone testing.
Attachment #289993 - Flags: review?(anodelman)
(Assignee)

Updated

11 years ago
Summary: Talos does fails on 10.5/Leopard: user does not exist → Talos fails on 10.5/Leopard: user does not exist

Updated

11 years ago
Assignee: nobody → mtschrep
looks good to me.
Comment on attachment 289993 [details] [diff] [review]
Patch to make talos run fine on 10.5

Looks good to me too.
Attachment #289993 - Flags: review?(anodelman) → review+
Checking in cmanager_mac.py;
/cvsroot/mozilla/testing/performance/talos/cmanager_mac.py,v  <--  cmanager_mac.py
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: Trunk → other

Updated

10 years ago
Component: Release Engineering: Talos → Release Engineering
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.