Closed Bug 405219 Opened 17 years ago Closed 17 years ago

system nspr, nss and cairo checks should bump their version checking

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
Currently, version >= 4.0.0 is checked, but just after that, check for existance of PR_STATIC_ASSERT is made. AFAICT, it is only present in nspr 4.7.0, so the version check should probably be bumped.
Attachment #290016 - Flags: review?(benjamin)
Assignee: nobody → mh+mozilla
Same applies with NSS, where TLS_DHE_RSA_WITH_CAMELLIA_256_CBC_SHA and others, that are only available in version 3.12.0, are used in mozilla code.

Sadly, the checks are actually not implemented in nspr.m4 and nss.m4...
Summary: system nspr check should bump it version checking → system nspr and nss checks should bump their version checking
Attached patch new patch (obsolete) — Splinter Review
Attachment #290016 - Attachment is obsolete: true
Attachment #290043 - Flags: review?(benjamin)
Attachment #290016 - Flags: review?(benjamin)
Same goes for cairo, which "experimental API" is used.
Summary: system nspr and nss checks should bump their version checking → system nspr, nss and cairo checks should bump their version checking
Attached patch new patchSplinter Review
Attachment #290043 - Attachment is obsolete: true
Attachment #290044 - Flags: review?(benjamin)
Attachment #290043 - Flags: review?(benjamin)
Depends on: 405290
By the way, I think configure should fail if the system nspr or nss don't match the given version, instead of configuring to use the internal ones. What do you think ?
Attachment #290044 - Flags: review?(benjamin) → review+
Attachment #290044 - Flags: approval1.9?
Comment on attachment 290044 [details] [diff] [review]
new patch

a=beltzner for drivers
Attachment #290044 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1892; previous revision: 1.1891
done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.