Closed
Bug 405219
Opened 17 years ago
Closed 17 years ago
system nspr, nss and cairo checks should bump their version checking
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 2 obsolete files)
896 bytes,
patch
|
benjamin
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Currently, version >= 4.0.0 is checked, but just after that, check for existance of PR_STATIC_ASSERT is made. AFAICT, it is only present in nspr 4.7.0, so the version check should probably be bumped.
Attachment #290016 -
Flags: review?(benjamin)
Updated•17 years ago
|
Assignee: nobody → mh+mozilla
Assignee | ||
Comment 1•17 years ago
|
||
Same applies with NSS, where TLS_DHE_RSA_WITH_CAMELLIA_256_CBC_SHA and others, that are only available in version 3.12.0, are used in mozilla code. Sadly, the checks are actually not implemented in nspr.m4 and nss.m4...
Summary: system nspr check should bump it version checking → system nspr and nss checks should bump their version checking
Assignee | ||
Comment 2•17 years ago
|
||
Attachment #290016 -
Attachment is obsolete: true
Attachment #290043 -
Flags: review?(benjamin)
Attachment #290016 -
Flags: review?(benjamin)
Assignee | ||
Comment 3•17 years ago
|
||
Same goes for cairo, which "experimental API" is used.
Assignee | ||
Updated•17 years ago
|
Summary: system nspr and nss checks should bump their version checking → system nspr, nss and cairo checks should bump their version checking
Assignee | ||
Comment 4•17 years ago
|
||
Attachment #290043 -
Attachment is obsolete: true
Attachment #290044 -
Flags: review?(benjamin)
Attachment #290043 -
Flags: review?(benjamin)
Assignee | ||
Comment 5•17 years ago
|
||
By the way, I think configure should fail if the system nspr or nss don't match the given version, instead of configuring to use the internal ones. What do you think ?
Updated•17 years ago
|
Attachment #290044 -
Flags: review?(benjamin) → review+
Updated•17 years ago
|
Attachment #290044 -
Flags: approval1.9?
Comment 6•17 years ago
|
||
Comment on attachment 290044 [details] [diff] [review] new patch a=beltzner for drivers
Attachment #290044 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Keywords: checkin-needed
Comment 7•17 years ago
|
||
Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1892; previous revision: 1.1891 done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•