405252 - View->Zoom not active when image is shown (no text)

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Jo Hermans]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112405 Minefield/3.0b2pre

When an image is shown, the View->Zoom menu is inactive, although the keyboard shortcuts work. This was appropriate when only text-zoom was done, but not for full page UI.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Should be as easy as removing http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/browser-menubar.inc&rev=1.120&mark=174#174 .

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(removing the |observes="isImage"| on that line, I mean)

Comment 3

[Florian Quèze [:florian]]

Attachment: patch v1

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 291971 [details] [diff] [review]
patch v1

I'm assuming you've tested this :)

Comment 5

[Florian Quèze [:florian]]

Yeah I tested this. I can't reproduce the bug on Mac, but I can on Windows. And on Windows the patch fixes it.

Comment 6

[Florian Quèze [:florian]]

Checking in browser/base/content/browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <--  browser-menubar.inc
new revision: 1.121; previous revision: 1.120
done

Comment 7

[Jo Hermans]

verified
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121305 Minefield/3.0b3pre

Comment 8

[Sylvain Pasche]

Disabling the Zoom in/out buttons could be useful in case "Zoom Text Only" is checked. Bug 427933 was filed about it.