405373 - Phantom/non-functional context menu still appears after doing a Clear List

Status: NEW

(Toolkit :: Downloads API, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112505 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112505 Minefield/3.0b2pre

When doing right click on empty space of Downloads, while there's a download going on, no options should appear.

Since there is no selected download.


Reproducible: Always

Comment 1

[Marco Bonardo [:mak]]

from what i see here, there is always a selected download...

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007112605 Minefield/3.0b2pre

Comment 2

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre) Gecko/2007120304 Minefield/3.0b2pre

If I choose Clear List, the menu with all those items still appears until I reopen the dialog.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Yup, I see this too.  Confirming the bug -> NEW

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Are we not flushing the rich listbox's tree (or whatever that is) after doing a "Clear List"?

Comment 5

[:Gavin Sharp [email: [e-mail]]]

This looks like a richlistbox bug, actually. We remove the elements from the richlistbox, but its selectedItems array isn't updated, so its selectedItem getter still returns the previously selected element. Could fix this on the DM side by explicitly setting selectedItem to null, or using a richlistbox method to do the removals, I guess, but I wonder whether the listbox-base binding should handle this case better.

Comment 6

[Neil Deakin]

If that's the reason, then it would be fixed by bug 331513 presumably.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Seems likely. I tried testing the patch but it doesn't apply to current trunk.

Comment 8

[Nikos Platis]

The current behavior is that the context menu that appears corresponds to the selected download, even if you right-click on the empty space of the Download Manager window. This is completely wrong, because clicking on the empty space should bring up a context menu suitable for the empty space (possibly containing only generic options such as "Clear List".

Maybe the context menu issues fit in Bug 397655 ?

Comment 9

[Andrés Delfino]

(In reply to comment #8)
> The current behavior is that the context menu that appears corresponds to the
> selected download, even if you right-click on the empty space of the Download
> Manager window. This is completely wrong, because clicking on the empty space
> should bring up a context menu suitable for the empty space (possibly
> containing only generic options such as "Clear List".
> 
> Maybe the context menu issues fit in Bug 397655 ?
> 

I'd think so if the mock ups of that bug would deal with context menu of empty space.

Comment 10

[Nikos Platis]

This seems to work more or less correctly in latest nightlies of Firefox 3:
 - In a clear list, no context menu appears
 - If I deselect the selected item by Ctrl+click, so that no item is selected, then right-click on the empty space does not bring up a context menu.

However, if there is a selected item, clicking on the empty space does bring up the context menu relevant to the selected item, which is still wrong, since the correct behavior when right-clicking on the empty space would be to deselect any previously selected item and bring up a context menu suitable for the empty space.