Closed Bug 405418 Opened 17 years ago Closed 17 years ago

Calendar color is not applied immediately to ICS calendars

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: andreas.treumann, Assigned: dbo)

References

Details

(Keywords: regression)

Attachments

(1 file)

STEPS TO REPRODUCE:
===================

- create a ICS-Network calendar (file:///c:/test.ics) or use a webdav server
- use a non default color for this calendar

RESULT:
=======

- the calendar has no color in the calendar list
- events of this calendar get the default color (blue)

EXPECTED RESULT:
================

- the calendar and events should be visible in the correct color. 

REPRODUCIBLE:
=============

- always


This bug doesn't occur with new local calendars or new WCAP calendars.
Regression Range:
  WORKS in Lightning 0.8pre (2007-11-20-04) + Tb 2.0.0.10pre (20071126)
  FAILS in Lightning 0.8pre (2007-11-21-03) + Tb 2.0.0.10pre (20071126)
    
Checkins during regression range: http://tinyurl.com/ysp4bx
Possible causer: Bug 341776, Bug 404085
IMO should be fixed for 0.8
Flags: wanted-calendar0.8?
Version: Trunk → unspecified
The same issues happens if you change the calendar color for existing calendars. It requires an application restart to apply the changes.

Philipp, this seems to be caused by your provider changes for Bug 341776 or Bug 404085. Maybe you can take a look if there was something missed.
Summary: New ICS-Network calendar -> calendar shows wrong color → Calendar color is not applied immediately to ICS calendars
Maybe this helps:

If I change the color for a storage calendar the function setProperty() in calProviderBase.js is called.

If I do the same for an ics calendar this function is not called.
Attached patch fixSplinter Review
regression of bug 404085
Assignee: Berend.Cornelius → daniel.boelzle
Status: NEW → ASSIGNED
Attachment #292998 - Flags: review?(philipp)
Comment on attachment 292998 [details] [diff] [review]
fix

>+    get observers() {
>+        return this.mObservers;
>+    },
>+
Since observers is not part of the interface anyway, you can go ahead and use  |this.mCalendar.mObservers| below.


> function calICSObserver(aCalendar) {
>     this.mCalendar = aCalendar;
>     this.mObservers = new calListenerBag(Components.interfaces.calIObserver);
> }
Initialization of this.mObservers should be removed

r=philipp
Attachment #292998 - Flags: review?(philipp) → review+
(In reply to comment #7)
> (From update of attachment 292998 [details] [diff] [review])
> >+    get observers() {
> >+        return this.mObservers;
> >+    },
> >+
> Since observers is not part of the interface anyway, you can go ahead and use 
> |this.mCalendar.mObservers| below.
My intention was to make the observers getter part of the base provider interface, thus I stick to using it.

> > function calICSObserver(aCalendar) {
> >     this.mCalendar = aCalendar;
> >     this.mObservers = new calListenerBag(Components.interfaces.calIObserver);
> > }
> Initialization of this.mObservers should be removed
done that


Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.8
I tested with lightning build 2007121104 and I don't see this fix working for imported calendars. What I did was imported an ics file with some events in it with a non-default colour (dark grey). All the events loaded in the default colour. I had to restart thunderbird to see the color change. Let me know if I am doing the test incorrectly. Thanks.
(In reply to comment #9)
> I tested with lightning build 2007121104.
[...]
> Let me know if I am doing the test incorrectly.

Parvata,
the patch was checked in at 2007-12-15 11:02 PST. So you will see it in the next nightly build between 2007-12-16 03:00 PST and 06:00 PST. You're using an "old" nightly build of Lightning (i.e. 2007121104). Please try to verify bugs with the latest nightly builds you can find at http://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/latest-mozilla1.8/.

Thanks for verifying fixed bugs. :)
With the latest build I can confirm this bug fixed with local .ics files.
VERIFIED FIXED based on comment 11.
Status: RESOLVED → VERIFIED
Flags: wanted-calendar0.8?
You need to log in before you can comment on or make changes to this bug.