405488 - Hide and show (collapsed) option of Wikipedia's templates does not work.

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: English US, defect)

Description

[Carlos Roberto]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b1) Gecko/2007110904 Firefox/3.0b1

Wikipedia has a option to collapse (hide and show) the whole templates. However Firefox 3b1 does not work and the template kept opened.

Reproducible: Always

Steps to Reproduce:
1. Open http://en.wikipedia.org/wiki/Template:Strength_training_exercises with Firefox 2, you will notice that you get a hide and show button and the template is collapsed.
2. Open the same url with Firefox 3b1, you will notice that the template is not collapsed and you do not get a hide and show button.
Actual Results:  
Template is not collapsed and you do not have a hide and show option

Expected Results:  
Template should be opened in a collapse mode and you should have a hide and show button.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Confirming.  The regression range seems to be:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-07-26+01&maxdate=2007-07-27+04&cvsroot=%2Fcvsroot

The issue is that collapseCaption is for some reason undefined instead of having the value it should have. Just try this after loading the page, both on trunk and on branch:

  javascript:void(alert(collapseCaption))

I'm betting on bug 367911 here.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Blake, this looks like possible XOW fallout?

I also see attachEvent exceptions on trunk that I don't see on branch... maybe that's somehow responsible?

Comment 3

[Boris Zbarsky [:bzbarsky]]

It would be great to get a testcase attached to this bug in case the page changes, by the way.  Doesn't have to be minimal or anything, just show the bug.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Oh, nevermind.  That range is when we landed showModalDialog support, and the page in question has:

  if (window.showModalDialog && document.compatMode && document.compatMode == "CSS1Compat") {
    // Do IE stuff here, including attachEvent
  }

That throws and then the line that sets collapseCaption is never evaluated.

So looks like a site bug.  If they want to be detecting IE, it should detect IE.  

Comment 5

[Chris Lawson (gone)]

Has anyone contacted the MediaWiki folks and filed a bug with them?

http://bugzilla.wikimedia.org/

Comment 6

[Carlos Roberto]

Note: this bug was reported on MediaWiki bugzilla.

http://bugzilla.wikimedia.org/show_bug.cgi?id=12157

Comment 7

[Brion Vibber]

Problem seems to have been a mysterious "IE bug fix" in en.wikipedia.org's customized MediaWiki:Common.js, which has bogus detection and so incorrectly triggers on Firefox 3.0 (as noted here).

I've commented that out and requested that if it's restored it should be done with correct detection: http://en.wikipedia.org/w/index.php?title=MediaWiki:Common.js&diff=174854479&oldid=172125518

Comment 8

[Boris Zbarsky [:bzbarsky]]

Brion, thanks for the quick fix!