405502 - Imported task is displayed twice in task list

Status: VERIFIED FIXED

(Calendar :: Tasks, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: ics testcase

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.10pre) Gecko/2007112606 Calendar/0.8pre

Steps To Reproduce:
1. Start Sunbird with clean profile
2. Import the attached ics file containing one task with start and due date
3. Check the task list

Actual results:
The task "Sample Task" is shown twice in the task list.

Regression Range:
  WORKS in Sunbird 0.8pre (2007-11-21-05)
  FAILS in Sunbird 0.8pre (2007-11-22-05)

Checkins during regression range: http://tinyurl.com/32ko8c

Seems to be caused by the checkin for Bug 253396.

Comment 1

[Michael Büttner (no reviews TFN)]

Attachment: patch v1

The import code doesn't play nice and comes up with overlapping calls to start/end batch plus the fact that the task tree didn't shield itself from items that try getting added more than once. this patch is an attempt to make this particular part of the tree more robust.

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 292423 [details] [diff] [review]
patch v1

>+              if (index == undefined) {
I'd prefer the stronger ===.

>+                  this.binding.mTaskArray.push(aItem);
>+                  var index = this.binding.mTaskArray.length - 1;
exchange these lines and save the -1.

r=dbo

Comment 3

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 4

[Stefan Sitter [:ssitter]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.12pre) Gecko/2007121105 Calendar/0.8pre.