405572 - Offer alternative UUID format for CID

Status: RESOLVED FIXED

(Webtools Graveyard :: Mozbot, enhancement, P1)

Description

[u278084]

Attachment: first attempt

Some developers, especially those new to Mozilla development, don't immediately pick up the connection between :

065dca73-3761-4dbc-a831-a2ebbcc536cb
and 
{0x065dca73, 0x3761, 0x4dbc, {0xa8, 0x31, 0xa2, 0xeb, 0xbc, 0xc5, 0x36, 0xcb}}

And they don't like to do the conversion. So attached is something to output UUID and CID in the same line when someone asks for a uuid. Maybe this should be put into it's own module/command? like |mozbot : cid|?

Yes my perl is rather sketchy.

Comment 1

[Wolf [:wolf]]

Comment on attachment 290338 [details] [diff] [review]
first attempt

Thanks for the work on this. Code-wise things look good, don't see any problems there.

UI-wise though:
Yeah, it should be implemented as a seperate command, cid is a good name for it, imo

Addtionally, to help with discoverability, it'd be nice to have a short msg appended to the current uuid output that just says something like "/msg $botnick cid for cid form."

Comment 2

[u278084]

Attachment: second attempt

CID is now it's own command. As well, there is a section in the help subroutine for it. Not asking for review until I get a clarification about whether we can actually get the bot name (it seems to be hardcoded in other places).

Comment 3

[u278084]

Attachment: Third patch is the charm

As if on cue. yes, it is possible. Uploading fixed version.

Comment 4

[Wolf [:wolf]]

Comment on attachment 348301 [details] [diff] [review]
Third patch is the charm

Looks good to me. :-)

You want to check it in or would you prefer me to?

Comment 5

[u278084]

(In reply to comment #4)
> You want to check it in or would you prefer me to?
If you can, that will be swell.

Comment 6

[Wolf [:wolf]]

(In reply to comment #5)
> If you can, that will be swell.

No problem. :-)

Comment 7

[Wolf [:wolf]]

Checking in BotModules/UUIDGen.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/UUIDGen.bm,v  <--  UUIDGen.bm
new revision: 2.1; previous revision: 2.0
done