405685 - url-classifier needs to check phishing and malware prefs separately.

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Dave Camp (:dcamp)]

Attachment: check both prefs

Bug 399233 changed phishing protection to use the url classifier, but we forgot to update the url-classifier to check both prefs.

Comment 1

[Tony Chang (Google)]

Comment on attachment 290448 [details] [diff] [review]
check both prefs

Looks good.

It's probably sufficient to pass bools instead of a ptr to the service.  I think it's ok to make the decision whether or not to check at the time the callback is created and it makes things a little simpler.  Anyway, not a big deal either way.

Comment 2

[Dave Camp (:dcamp)]

Attachment: v2

updated with tony's comment.

Asking for approval since I haven't gotten blocking+ yet, this is a pretty significant bug.

Comment 3

[Dave Camp (:dcamp)]

Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v  <--  nsUrlClassifierDBService.cpp
new revision: 1.41; previous revision: 1.40
done
Checking in src/nsUrlClassifierDBService.h;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.h,v  <--  nsUrlClassifierDBService.h
new revision: 1.5; previous revision: 1.4
done