Closed Bug 405741 Opened 17 years ago Closed 17 years ago

nsIDOMFileList naming not consistent - fileList vs files

Categories

(Core :: DOM: Core & HTML, defect, P3)

x86
Windows XP
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: BijuMailList, Assigned: dcamp)

References

Details

Attachments

(1 file)

Created per Bug #403856 Comment #3 nsIDOMFileList naming not consistent with other DOM or JS objects +++ This bug was initially created as a clone of Bug #403856 +++ Issue 2. ======== fileList vs files Always we used the plural form of the item name to represent Collection/List Example arguments documenrt.links selection_element.options documenrt.plugins documenrt.embeds documenrt.anchors documenrt.forms documenrt.applets documenrt.images But for nsIDOMFileList we appended word "List" to the item name Expected by convention: just "files"
Doesn't look like there's a spec covering this, so I'd say we should just go ahead and change this. Patches accepted, should be trivial.
Asking for blocking to keep this on my radar
Flags: blocking1.9?
Attached patch quick fixSplinter Review
Attachment #292708 - Flags: superreview?(jonas)
Attachment #292708 - Flags: review?(jonas)
Comment on attachment 292708 [details] [diff] [review] quick fix sold!
Attachment #292708 - Flags: superreview?(jonas)
Attachment #292708 - Flags: superreview+
Attachment #292708 - Flags: review?(jonas)
Attachment #292708 - Flags: review+
Attachment #292708 - Flags: approval1.9+
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Assignee: nobody → dcamp
Checking in content/html/content/src/nsHTMLInputElement.cpp; /cvsroot/mozilla/content/html/content/src/nsHTMLInputElement.cpp,v <-- nsHTMLInputElement.cpp new revision: 1.469; previous revision: 1.468 done Checking in dom/public/idl/html/nsIDOMNSHTMLInputElement.idl; /cvsroot/mozilla/dom/public/idl/html/nsIDOMNSHTMLInputElement.idl,v <-- nsIDOMNSHTMLInputElement.idl new revision: 1.13; previous revision: 1.12 done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
thanks Dave/Jonas ...
Depends on: 418256
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: