405755 - when viewing a saved search in the bookmark sidebar, the children aren't visible

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

when viewing a saved search in the bookmark sidebar, the children aren't visible

steps to reproduce:

1)  go to the places organizer
2)  search on "ca"
3)  save the search, name it "ca search" 

right now, that gives you:

place:terms=ca&excludeQueries=1&expandQueries=0&queryType=1

4)  open the bookmarks sidebar.
5)  you will see the "ca search" item, but it will not have any children.

Note, if the query was:

place:terms=ca&queryType=1

The children would be visible in the bookmarks sidebar.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

this destroys consistency of using saved searches in given places

Comment 2

[Giles Weaver]

This is still a problem in beta3...

Comment 3

[Dietrich Ayala (:dietrich)]

Attachment: fix

force query expansion for saved searches

Comment 4

[Asaf Romano (gone)]

Comment on attachment 307102 [details] [diff] [review]
fix

I would add "unset exapndQueries=false, which is set by the left pane".

r=mano.

Comment 5

[Dietrich Ayala (:dietrich)]

Attachment: for checkin

changed comment, carrying over review

Comment 6

[Dietrich Ayala (:dietrich)]

"/private/var/folders/mg/mgokf6s1FsauxPSflXbZV++++TI/-Tmp-/cvs5DwXz0" 9L, 431C written
Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.136; previous revision: 1.135
done

Comment 7

[Tracy Walker [:tracy]]

verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032606
Firefox/3.0b5
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-GB; rv:1.9b5)
Gecko/2008032604 Firefox/3.0b5

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv