Closed Bug 405755 Opened 15 years ago Closed 15 years ago

when viewing a saved search in the bookmark sidebar, the children aren't visible

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: moco, Assigned: dietrich)

Details

Attachments

(1 file, 1 obsolete file)

when viewing a saved search in the bookmark sidebar, the children aren't visible

steps to reproduce:

1)  go to the places organizer
2)  search on "ca"
3)  save the search, name it "ca search" 

right now, that gives you:

place:terms=ca&excludeQueries=1&expandQueries=0&queryType=1

4)  open the bookmarks sidebar.
5)  you will see the "ca search" item, but it will not have any children.

Note, if the query was:

place:terms=ca&queryType=1

The children would be visible in the bookmarks sidebar.
this destroys consistency of using saved searches in given places
Flags: blocking-firefox3?
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Target Milestone: --- → Firefox 3 beta4
This is still a problem in beta3...
Target Milestone: Firefox 3 beta4 → Firefox 3
Assignee: nobody → dietrich
Attached patch fix (obsolete) — Splinter Review
force query expansion for saved searches
Attachment #307102 - Flags: review?(mano)
Whiteboard: [has patch][needs review mano]
Comment on attachment 307102 [details] [diff] [review]
fix

I would add "unset exapndQueries=false, which is set by the left pane".

r=mano.
Attachment #307102 - Flags: review?(mano) → review+
Attached patch for checkinSplinter Review
changed comment, carrying over review
Attachment #307102 - Attachment is obsolete: true
Attachment #307135 - Flags: review+
Whiteboard: [has patch][needs review mano] → [has patch][has review]
"/private/var/folders/mg/mgokf6s1FsauxPSflXbZV++++TI/-Tmp-/cvs5DwXz0" 9L, 431C written
Checking in browser/components/places/content/places.js;
/cvsroot/mozilla/browser/components/places/content/places.js,v  <--  places.js
new revision: 1.136; previous revision: 1.135
done
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032606
Firefox/3.0b5
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-GB; rv:1.9b5)
Gecko/2008032604 Firefox/3.0b5
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.