Closed Bug 405756 Opened 12 years ago Closed 12 years ago

be careful with coordinateType

Categories

(Core :: Disability Access APIs, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #290507 - Flags: review?(aaronleventhal)
eventually I forgot to make a changes for getImageBounds on linux side.
Attachment #290507 - Flags: review?(aaronleventhal)
Attachment #290507 - Flags: review?(Evan.Yan)
Attachment #290507 - Flags: review+
Attached patch patch2Splinter Review
Attachment #290507 - Attachment is obsolete: true
Attachment #290555 - Flags: review?(Evan.Yan)
Attachment #290507 - Flags: review?(Evan.Yan)
forgot to remove "nsresult rv = "
Comment on attachment 290555 [details] [diff] [review]
patch2

nit: it would be good to use the same arguments type for ConvertToScreenCoords() and ConvertScreenCoordsTo(), i.e. let both of them use aCoords for out parameter or use *aX/*aY.
Attachment #290555 - Flags: review?(Evan.Yan) → review+
(In reply to comment #4)
> (From update of attachment 290555 [details] [diff] [review])
> nit: it would be good to use the same arguments type for
> ConvertToScreenCoords() and ConvertScreenCoordsTo(), i.e. let both of them use
> aCoords for out parameter or use *aX/*aY.
> 

ConvertScreenCoordsTo() is used with out arguments but ConvertToScreenCoords() is used with in arguments. Therefore for ConvertScreenCoordsTo is good to pass *aX and *aY (it safes some code) but it's not good to modify in arugments in the case of ConvertToScreenCoords. If you're fine then I would like to save this.
Attachment #290555 - Flags: approval1.9?
Attachment #290555 - Flags: approval1.9? → approval1.9+
checked in
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.