405756 - be careful with coordinateType

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[alexander :surkov (:asurkov)]

eventually I forgot to make a changes for getImageBounds on linux side.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 3

[alexander :surkov (:asurkov)]

forgot to remove "nsresult rv = "

Comment 4

[Evan Yan]

Comment on attachment 290555 [details] [diff] [review]
patch2

nit: it would be good to use the same arguments type for ConvertToScreenCoords() and ConvertScreenCoordsTo(), i.e. let both of them use aCoords for out parameter or use *aX/*aY.

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> (From update of attachment 290555 [details] [diff] [review])
> nit: it would be good to use the same arguments type for
> ConvertToScreenCoords() and ConvertScreenCoordsTo(), i.e. let both of them use
> aCoords for out parameter or use *aX/*aY.
> 

ConvertScreenCoordsTo() is used with out arguments but ConvertToScreenCoords() is used with in arguments. Therefore for ConvertScreenCoordsTo is good to pass *aX and *aY (it safes some code) but it's not good to modify in arugments in the case of ConvertToScreenCoords. If you're fine then I would like to save this.

Comment 6

[alexander :surkov (:asurkov)]

checked in