405794 - Selected item(s) in dropdown list should be rendered natively

Status: VERIFIED DUPLICATE of bug 412092

(Firefox :: Address Bar, enhancement)

Description

[u294409]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.9) Gecko/20071105 Epiphany/2.20 Firefox/2.0.0.9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.8.1.9) Gecko/20071105 Epiphany/2.20 Firefox/2.0.0.9

autocomplete's elements shall be native menu or addressbar should be combobox with edit (there's such a component in gtk).

Reproducible: Always

Steps to Reproduce:
1. write in addressbar.
2. look at autocomplete's elements.
Actual Results:  
plain (strange) looking elements.

Expected Results:  
native menu-like elements.

attachment: http://img.wklej.org/images/57616zrzutekranu.png

Comment 1

[u294409]

* build id should be: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112804 Fedora/8 (Werewolf) Minefield/3.0b2pre

Comment 2

[Kevin Brosnan]

The autocomplete is going to be non-native and since you are using the trunk you should already have some of the experimental changes.

Comment 3

[u294409]

it MUST be native to make firefox integrate well with linux environment.
understood?

Comment 4

[u294409]

Attachment: screenshot of trunk - out-of-place look of autocomplete

Comment 5

[u294409]

ping

Comment 6

[u294409]

ping

Comment 7

[Steve England [:stevee]]

please do not request blocking for bugs that are not confirmed.

Comment 8

[u294409]

ping

Comment 9

[u294409]

ping

Comment 10

[Julien "_FrnchFrgg_" RIVAUD]

Jakub: What look should it have ? Did work on bug 405210 arrange something or not ? (it's fairly recent, check you have the new code on your trunk)

Comment 11

[u294409]

Dropdown button isn't an autocomplete's item.
They're now flat instead of being drawn as combobox' menu using GTK.

Comment 12

[Julien "_FrnchFrgg_" RIVAUD]

So what you ask is for the list that opens to look as a native one ? That is with a little outset border ?

Comment 13

[u294409]

No borders... OMG...

Firefox draws it without any gradients, etc, like non-GTK component.

I'll upload some screenys, which would show the issue.

Comment 14

[u294409]

Attachment: current firefox' autocomplete

Comment 15

[u294409]

Attachment: nice example of native gtk widget

Comment 16

[u294409]

Attachment: example of same ugly situation in native gtk (that widget should die)

Comment 17

[u294409]

Attachment: same ugly situation in gnome's run dialog

Comment 18

[u294409]

Hmmmm, GTK has same widget, but it's ugly and not used in most GTK apps.
Firefox should use the nicer widget for the same function (ComboBoxEntry instead of GtkCombo).

Comment 19

[Julien "_FrnchFrgg_" RIVAUD]

Jakub, we don't really "use" gtk widgets. We just ask the theme to draw bits of widgets for us. So we have to ask "draw a ComboboxEntry arrow button here with status pressed", etc...
The bug here (apart from the look of the drop-down list itself) is that we don't ask for the "pressed" look when the list is open. There was work on that at least for toolbar dropdown buttons, I'll see if I can find a similar bug for autocomplete entries, or else I'll use this bug.

Does that suit you ?

Comment 20

[u294409]

I'm not talking about BUTTONS!
Autocomplete items are ugly!

Comment 21

[Julien "_FrnchFrgg_" RIVAUD]

So your problem is that the selected element should be rendered with a two-color gradient instead of a flat color ? Your pb is that "ugly" isn't precise enough for bug correction.

Comment 22

[u294409]

Yes, exactly how GTK does for listview and treeview items.

Comment 23

[u294409]

Marking as dupe of 412092 even if "duped" is newer. There some work has began.

Comment 24

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified dup