405854 - only clicked links, bookmarks, typed in urls (or urls selected from autocomplete) should affect visit count (for autocomplete) and for "Have I visited this website before today" query?

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

only clicked links, bookmarks, typed in urls (or urls selected from autocomplete) should affect visit count (for autocomplete) and for "Have I visited this website before today" query?

we want to make sure that:

1)  POST result page should not appear in global history or history autocomplete results (ex, https://bugzilla.mozilla.org/process_bug.cgi), see bug #94514

2)  restarting from session restore doesn't count (as we'll be counting certain visits twice, and possibly counting excluded visits)

3)  meta refresh (see bug #399606)

4)  things like window.location.href, window.location, location.replace(), location.reload, javascript:history.go(), etc.

not sure if:  reload / shift reload, undo close tab, opening a new window (to your home page), or starting the browser to your home page should count (or not.)

note that fx3, unlike fx2, we "trust" visit count in both the url bar autocomplete and page info ("Have I visited this website before today?")

Comment 1

[Johnathan Nightingale [:johnath]]

I don't know if we care, but this list would mean dropping the visits resulting from legitimate "this site has moved, click here if you aren't redirected in 3 seconds..." pages.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

re comment 1: Would the original redirect site remain? If so I don't know if I care that much, and would rather not have the perfect beat up the good.

Comment 3

[Mike Connor [:mconnor]]

Can we tell what the redirect is?  If I click a bookmark and get a 301 redirect, that visit shouldn't be a redirect visit, it should be a bookmark visit.

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #0)
> 3)  meta refresh (see bug #399606)
> 
> 4)  things like window.location.href, window.location, location.replace(),
> location.reload, javascript:history.go(), etc.
Both of these are now fixed with bug 399606.

Comment 5

[Dietrich Ayala (:dietrich)]

(In reply to comment #0)

> 
> 2)  restarting from session restore doesn't count (as we'll be counting certain
> visits twice, and possibly counting excluded visits)

i confirmed that restoring a session does not add new visits. apparently docshell won't call nsIGlobalHistory.addURI when loading a page from cache.

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> I don't know if we care, but this list would mean dropping the visits resulting
> from legitimate "this site has moved, click here if you aren't redirected in 3
> seconds..." pages.
FYI, this isn't actually the case.  We only drop the listing if it redirects to the same page.  If it redirects to a different one, we store it.

Taking bug, but it'll be resolved once I get bug 94514 resolved.

Comment 7

[Shawn Wilsher :sdwilsh]

We covered (1) with bug 94514 (note follow-up bug 415955).

We covered (2) via comment 5

We covered (3) via bug 399606

We covered (4) via bug 399606

We did not cover "not sure if:  reload / shift reload, undo close tab, opening a new window (to your home page), or starting the browser to your home page should count (or not.)", but I'm not sure if we should worry about those, especially in the fx3 timeframe.

At this point, I feel that this bug is resolved.

Comment 8

[Tracy Walker [:tracy]]

verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032606 Firefox/3.0b5
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-GB; rv:1.9b5) Gecko/2008032604 Firefox/3.0b5

Comment 9

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv