Closed Bug 405918 Opened 12 years ago Closed 2 years ago

[meta] clean up hacks from bug #399664

Categories

(Firefox :: Address Bar, defect)

defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: moco, Unassigned)

References

(Depends on 2 open bugs)

Details

For bug #399664 (not yet landed, but in gavin's review queue), I've got three hacks (see below) I'd like to figure out how to remove.

1)  "faking" the ellipsis.

bug #404427 ("for description elements, crop only works if you use the value attribute")
or
bug #312156 ("implement text-overflow: ellipsis from CSS3 text")

+          setTimeout(function(self) { self._setUpEllipsis(aScrollBoxObject, aDescriptionElement, aEllipsis); }, 0, this);

2) bug #405913 – wanted: richlisttree

+            if (!this._urlOverflowEllipsis.boxObject.width ||
+                !this._titleOverflowEllipsis.boxObject.width)
+              setTimeout(function(self) { self._adjustWidth(); }, 0, this);
+            else
+              this._adjustWidth();

3)  bug #401939 – support "rows" attribute on richlistbox (like we do on listbox)

+          // until we have support for "rows" on richlistbox,
+          // determine the height dynamically.  (see bug #401939)
+          if (!this._rowHeight && this.richlistbox.childNodes.length)
+            this._rowHeight = this.richlistbox.childNodes[0].boxObject.height;
+
+          var height = this._rowHeight * rows;
+          if (this._rowHeight && this.richlistbox.height != height)
+            this.richlistbox.height = height;
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
I think we're either happy with everything as it stands or waiting on new technology for the address bar. Therefore I think we can just close this off, as it doesn't feel like a useful meta.
Status: NEW → RESOLVED
Closed: 2 years ago
Component: Bookmarks & History → Address Bar
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.