extensions and external applications can directly access places.sqlite

RESOLVED INVALID

Status

()

Firefox
Bookmarks & History
RESOLVED INVALID
10 years ago
8 years ago

People

(Reporter: dietrich, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
not sure if this is fixable, nor desirable in some instances.
(Reporter)

Updated

10 years ago
Blocks: 375898
(In reply to comment #0)
> not sure if this is fixable, nor desirable in some instances.

Assuming http://developer.mozilla.org/en/docs/Storage#How_to_corrupt_your_database is still true I think it could cause major problems for places if extenal applications (google desktop?) start trying to access it. I'm also nevous for the same reason if this is taken up in mailnews (especially address book).
if I remember right from the security review, this is more about:

for external applications, it was "what if another application tries to inject malicious data into places.sqlite or read the data stored in it?"

as pointed out many times, once you are on the users machine (or running as an extension, at least currently), the game is over.

for extensions, I think the question was, "what if another extension attempts to open places.sqlite, using either mozStorage or directly?"  for directly, again, at least right now, extensions can do anything, so the game is over.

note, for places.sqlite, we do "pragma locking_mode = EXCLUSIVE" (see http://lxr.mozilla.org/seamonkey/source/toolkit/components/places/src/nsNavHistory.cpp#666) locking the database while firefox is running.

Comment 3

10 years ago
We can't prevent other apps with the same privileges from accessing our data, and based on comment 2, it sounds like we're doing the right thing to discourage other sqlite apps from touching the database while we're using.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → INVALID
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.