406028 - Call callback immediately when install is blocked

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[Dave Townsend [:mossop]]

When an install is blocked we currently retain the callback in case the user hits the new allow button. This can cause issues including the crash in bug 401624. The plan is to just call the callback and tell it that the install was blocked then drop the callback.

This means that the callback function becomes less useful for web developers.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This is a fairly simple patch, we just only retain the callback if we are whitelisted and going directly to the install stage. This makes us consistent with the 1.8 branch behaviour ignoring the fact that blocked install attempts can be restarted at a later point without the website knowing.

The field reordering in nsXPIInstallInfo.h just cleans up a compile time warning.

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 292395 [details] [diff] [review]
patch rev 1

r/sr=dveditz

Comment 3

[Dave Townsend [:mossop]]

Checking in xpinstall/src/nsJSInstallTriggerGlobal.cpp;
/cvsroot/mozilla/xpinstall/src/nsJSInstallTriggerGlobal.cpp,v  <--  nsJSInstallTriggerGlobal.cpp
new revision: 1.61; previous revision: 1.60
done
Checking in xpinstall/src/nsXPIInstallInfo.h;
/cvsroot/mozilla/xpinstall/src/nsXPIInstallInfo.h,v  <--  nsXPIInstallInfo.h
new revision: 1.2; previous revision: 1.1
done