Closed
Bug 406160
Opened 17 years ago
Closed 15 years ago
user configuration for browser.sessionhistory.max_entries ignored
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: tuukka.tolvanen, Assigned: timeless)
References
()
Details
Attachments
(1 file)
|
4.23 KB,
patch
|
Biesinger
:
review+
|
Details | Diff | Splinter Review |
gee, thanks for silently ignoring reasonable user-set values too rather than clamping only bogus values to the app default. I'd hate it if I'd have wasted time testing for side-effects of a bunch of values for this by tweaking the user configuration! That totally didn't happen though! At all! Because I checked the direct effect of setting the pref rather than just assuming it works! Honest! :|
note: with this code you can set any unreasonable value you like and use it for your entire session. the next session though if your value is unreasonable, you'll get a default :).
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
|
||
Comment 2•15 years ago
|
||
Comment on attachment 309387 [details] [diff] [review] honor live changes I wouldn't have minded doing the check for unreasonable values in UpdatePrefs, but I don't really care.
Attachment #309387 -
Flags: review?(cbiesinger) → review+
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/301603e7b9d8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•