406230 - Vertically align download icons in the center

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Attachment: screenshot of v1

per madhava on irc

(this is compared to top aligned as in attachment 290851 [details] [diff] [review])

Comment 1

[Ed Lee :Mardak]

Attachment: v1

pack start -> center (and some trailing spaces)

Comment 2

[Ed Lee :Mardak]

(In reply to comment #0)
> (this is compared to top aligned as in attachment...)
whoops. meant attachment 290850 [details]

Comment 3

[Ed Lee :Mardak]

Attachment: v1.1

Add in the download-dirty binding

Comment 4

[Shawn Wilsher :sdwilsh]

Comment on attachment 291342 [details] [diff] [review]
v1.1

r=sdwilsh

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 291342 [details] [diff] [review]
v1.1

a=beltzner

Comment 6

[Ed Lee :Mardak]

Checking in toolkit/mozapps/downloads/content/download.xml;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/download.xml,v  <--  download.xml
new revision: 1.45; previous revision: 1.44
done

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Still centered on Linux (Ubuntu), but looks different due to icon and font sizes there.

I don't think it's a big deal, and is probably expected; if anyone disagrees, please file a new bug.

Verified FIXED with:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007121704 Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007121704 Minefield/3.0b3pre

and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2007121705 Minefield/3.0b3pre

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Not worth a Litmus test for this, I feel...