406255 - emphasize the first matching text in both title and url

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

emphasize matching text in both title and url

right now, we underline the match in title, and if not title, then url.

we could (easily) underline the first match in both title and url, if that would be valuable.

note, underling all matches would not be so easy.

Comment 1

[(not reading, please use [e-mail] instead)]

> note, underling all matches would not be so easy.

see bug #407944 and bug #407946

Comment 2

[(not reading, please use [e-mail] instead)]

faaborg/beltzner, do we want this?

Comment 3

[Foteos Macrides]

(In reply to comment #0)
> we could (easily) underline the first match in both title and url, if that
> would be valuable.

That indeed would be quite valuable to those who often are focusing on the URLs because the titles in the documents of interest are the same or very similar, or otherwise poor for discriminating among the hits (e.g., because one is seeking the set of documents with hits in a particular component of the URL fields, per se).  So if it could "easily" be done, please do it.

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 6

[(not reading, please use [e-mail] instead)]

I think we want this, but it's up to the ux-folks.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

yes, we definitely want this.

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 294586 [details] [diff] [review]
patch

seeking approval for 1.9

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 294586 [details] [diff] [review]
patch

a=beltzner; I'll miss you most of all, scarecrow

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

Checking in toolkit/content/widgets/autocomplete.xml;
/cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v  <--  autocomplete.xml
new revision: 1.105; previous revision: 1.104
done

adding litmus-? so that we remember to write some tests and so that QA knows about the change in the behavior.

Comment 11

[(not reading, please use [e-mail] instead)]

please note that when the match is due to a tag, the matching text in neither title nor url are emphasized.

That was by design, but perhaps that should be revisited.  see bug #411963

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5117

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

I'm not verifying the full algorithm; just that we now match both title and URL...