406387 - Move System Defaults from Main to Advanced - General

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Robert Strong (they/them - no direct email)]

Per email discussion with beltzner we should move System Defaults from the Main prefpane to the Advanced prefpane's General tab panel. This is now possible with the landing of Bug 143065 which restricts accesskeys to an individual tab panel.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Also added missing accesskey for clearing the cache and removed period from the add-ons mgr description for consistency with the rest of the UI.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

try this again...

I've also added missing accesskey for clearing the cache and removed period from the add-ons mgr description for consistency with the rest of the UI.

note: I'd appreciate testing of this patch on Linux and Mac OS X in order to verify the new height is ok.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: screenshot

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2 (missed add-ons mgr desc changes)

Comment 5

[Robert Strong (they/them - no direct email)]

Filed Bug 406670 for the prefwindow extending on Mac OS X when going from the tabs prefpane to the apps prefpane

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 291037 [details] [diff] [review]
patch rev2 (missed add-ons mgr desc changes)

r=sspitzer

I also tested this out on my mac build.

1)  robert tells me that the accepted practice is to rename the entities, even on just punctuation changes (so that localizers are aware of it.)

2)  robert plans to use 40em, instead of 39em (on mac)

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch rev3 (updated min-height)

Carrying forward Seth's r+

Drivers, I'd like to get this in for M10. Some people still use screen resolutions that don't accommodate the current prefwindow size due to poor eyesight... this lessens the height to be 1em smaller than it was prior to adding the Manage Add-ons... button by moving the System Defaults from the Main pane over to the Advanced pane -> General tab which makes it possible to lessen the height. It also adds a missing access key and makes the description for managing add-ons consistent with the rest of the prefpane descriptions by removing a period at the end of the description.

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/browser/components/preferences/main.xul;
/cvsroot/mozilla/browser/components/preferences/main.xul,v  <--  main.xul
new revision: 1.16; previous revision: 1.15
done
Checking in mozilla/browser/components/preferences/main.js;
/cvsroot/mozilla/browser/components/preferences/main.js,v  <--  main.js
new revision: 1.15; previous revision: 1.14
done
Checking in mozilla/browser/components/preferences/advanced.xul;
/cvsroot/mozilla/browser/components/preferences/advanced.xul,v  <--  advanced.xul
new revision: 1.43; previous revision: 1.42
done
Checking in mozilla/browser/components/preferences/advanced.js;
/cvsroot/mozilla/browser/components/preferences/advanced.js,v  <--  advanced.js
new revision: 1.28; previous revision: 1.27
done
Checking in mozilla/browser/components/preferences/preferences.xul;
/cvsroot/mozilla/browser/components/preferences/preferences.xul,v  <--  preferences.xul
new revision: 1.17; previous revision: 1.16
done
Checking in mozilla/browser/locales/en-US/chrome/browser/preferences/main.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/main.dtd,v  <--  main.dtd
new revision: 1.9; previous revision: 1.8
done
Checking in mozilla/browser/locales/en-US/chrome/browser/preferences/advanced.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/advanced.dtd,v  <--  advanced.dtd
new revision: 1.28; previous revision: 1.27
done
Checking in mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.dtd,v  <--  preferences.dtd
new revision: 1.12; previous revision: 1.11
done

Comment 9

[Robert Strong (they/them - no direct email)]

Filed bug 406701 to update the help docs.

Comment 10

[Cheng Khoon]

Could this have caused bug 406785?

Comment 11

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120405 Minefield/3.0b2pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120404 Minefield/3.0b2pre.

Comment 12

[Marcia Knous [:marcia]]

Existing testcase in Preferences area has been updated in Litmus.

Comment 13

[Chris Ilias [:cilias]]

(In reply to comment #0)
> Per email discussion with beltzner we should move System Defaults from the Main
> prefpane to the Advanced prefpane's General tab panel. 

What was the reasoning behind this? (Note: I'm not disagreeing with the decision. I'm more indifferent to the decision. It's just that I've got a user in mozilla.support.firefox asking about the change; and I'd love to state the reason for the change. I can usually track these down via MXR>CVS_Blame>Bug_number, but when the bug only states "Per email discussion..." the general public is left in the dark.)

Comment 14

[Robert Strong (they/them - no direct email)]

The reasoning is that it isn't an option that is typically used often and moving it allows shortening the height of the prefwindow.

Comment 15

[Chris Ilias [:cilias]]

Thanks. If anyone's interested, the mozilla.support.firefox thread can be found at:
<http://groups.google.com/group/mozilla.support.firefox/browse_frm/thread/02a60be847602dba>