406626 - Make metrics extension build --with-libxul-sdk=/path/to/sdk --enable-application=extensions/metrics

Status: RESOLVED FIXED

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Description

[Benjamin Smedberg]

Attachment: Build metrics independently (as an option), rev. 1

This patch allows you to build the metrics extension it its own build tree without having to build all of mozilla. There is one functional change: the extension version number is now independent of the "mozilla" version number, which is I think what you want anyway. I've put it at '2a1' for now.

It is still possible to build metrics in a regular firefox build tree --enable-extensions=default,metrics if you desire.

Marking r?luser, and polvi is going to get the contractors doing the metrics extension to look this over as well.

Comment 1

[Alex Polvi]

pete, can you review this?

Comment 2

[Alex Polvi]

fwiw, landing this patch will help Mozilla create automated builds of the metrics extension.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 291274 [details] [diff] [review]
Build metrics independently (as an option), rev. 1

+++ extensions/metrics/src/Makefile.in	3 Dec 2007 20:29:35 -0000
@@ -59,33 +59,21 @@
 		  widget \
 		  libbz2 \
 		  xulapp \
 		  extensions \
 		  rdf \
 		  plugin \
 		  content \
 		  autocomplete \
+		  widget \
+		  places \

You double-listed widget here.

Comment 4

[Pete Collins (MDG)]

Attachment: tweaked patch

less the extra widget reference

Comment 5

[Pete Collins (MDG)]

patch checked in ...