Integrate various Tamarin fixes from the Adobe Flash source base

VERIFIED FIXED

Status

Tamarin
Virtual Machine
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 291319 [details] [diff] [review]
Patch to Tamarin.

This is a grab-bag of bug fixes and enhancements from the upcoming "Moviestar" version of Adobe Flash Player 9 Update 3 (version 9,0,115,0).
Attachment #291319 - Flags: review?(edwsmith)

Comment 1

10 years ago
Comment on attachment 291319 [details] [diff] [review]
Patch to Tamarin.

* added TR for review, much activity in gc/profiling code.

* DecimalClass.cpp line endinges changed?

* MethodEnv.cpp - is invocationCount++ intentional or leftover debug code.
Attachment #291319 - Flags: review?(treilly)
Attachment #291319 - Flags: review?(edwsmith)
Attachment #291319 - Flags: review+
(Assignee)

Comment 2

10 years ago
There were a couple of files with line ending issues (DecimalClass.cpp and something in PCRE). Not sure about invocationCount -- Tommy?

Comment 3

10 years ago
Invocation coount is part of the sampling API, see SamplerScript.cpp.  I've reviewed the GC changes too, they're good.

Updated

10 years ago
Attachment #291319 - Flags: review?(treilly) → review+
(Assignee)

Comment 4

10 years ago
pushed as changeset:   238:3c5220033898
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 5

10 years ago
Comment on attachment 291319 [details] [diff] [review]
Patch to Tamarin.

Does anyone recall why the buffer estimate logic was modified to reduce the request?  Was there a particular bug.

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.