406663 - ASSERTION: ResultNodeForContainer expects a valid item id

Status: RESOLVED INVALID

(Firefox :: Bookmarks & History, defect)

Description

[Martijn Wargers (dead)]

I'm seeing these assertions and warnings when opening the bookmarks manager:
*** Node URI: place:folder=755&expandQueries=0
###!!! ASSERTION: ResultNodeForContainer expects a valid item id: 'results', fil
e c:/mozilla-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, lin
e 1915
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/storage/src/mozStorageStatement.cpp, line 668
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 1921
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistory.cpp, line 4784
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 2015
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp, line 2928
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp, line 2769
###!!! ASSERTION: ResultNodeForContainer expects a valid item id: 'results', fil
e c:/mozilla-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, lin
e 1915
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/storage/src/mozStorageStatement.cpp, line 668
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 1921
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistory.cpp, line 4784
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 2015
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp, line 2928
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp, line 2769
###!!! ASSERTION: Should not be called: 'Not Reached', file c:\mozilla-build\moz
illa\layout\xul\base\src\grid\nsGridLayout2.h, line 78
JavaScript strict warning: chrome://inspector/content/inspector.xml, line 455: r
eference to undefined property event.originalTarget.nodeType
JavaScript strict warning: chrome://inspector/content/inspector.xml, line 455: r
eference to undefined property event.originalTarget.nodeType
An error occurred updating the cmd_selectAll command
JavaScript strict warning: chrome://inspector/content/inspector.xml, line 455: r
eference to undefined property event.originalTarget.nodeType
JavaScript strict warning: chrome://inspector/content/inspector.xml, line 455: r
eference to undefined property event.originalTarget.nodeType
An error occurred updating the cmd_selectAll command
An error occurred updating the cmd_selectAll command
An error occurred updating the cmd_selectAll command
###!!! ASSERTION: We are trying to fill children when there already are some: 'm
Children.Count() == 0', file c:/mozilla-build/mozilla/toolkit/components/places/
src/nsNavHistoryResult.cpp, line 2921
###!!! ASSERTION: ResultNodeForContainer expects a valid item id: 'results', fil
e c:/mozilla-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, lin
e 1915
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/storage/src/mozStorageStatement.cpp, line 668
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 1921
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistory.cpp, line 4784
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 2015
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp, line 2928
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file c:/mozill
a-build/mozilla/toolkit/components/places/src/nsNavHistoryResult.cpp, line 2807
###!!! ASSERTION: We are trying to fill children when there already are some: 'm
Children.Count() == 0', file c:/mozilla-build/mozilla/toolkit/components/places/
src/nsNavHistoryResult.cpp, line 2921

I can give my profile or bookmarks file, if needed.

Comment 1

[Martijn Wargers (dead)]

I guess it might be related to the fact, that the bookmarks manager is useless for me.
I can't expand the "All Bookmarks" at all and when right-clicking on that folder, I get:
Error: uncaught exception: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsINavHistoryContainerResultNode.childCount]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: chrome://browser/content/places/utils.js :: PU_getURLsForContainerNode :: line 1521"  data: no]
in the error console.

Comment 2

[Marco Bonardo [:mak]]

not expandable "all bookmarks" should be due to the removal of one of the roots (toolbar, menu, unfiled), they should not be removable, movable or similar.

i think it depends on Bug 406089 and Bug 405237

Comment 3

[(not reading, please use [e-mail] instead)]

Martijn, you might be running into bug #407296

Comment 4

[(not reading, please use [e-mail] instead)]

I just hit bug #407296 and from my console:

###!!! ASSERTION: ResultNodeForContainer expects a valid item id: 'results', file /Users/sspitzer/Desktop/trunk/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 1921
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file /Users/sspitzer/Desktop/trunk/mozilla/storage/src/mozStorageStatement.cpp, line 668
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file /Users/sspitzer/Desktop/trunk/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp, line 1927
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file /Users/sspitzer/Desktop/trunk/mozilla/toolkit/components/places/src/nsNavHistory.cpp, line 2232
JavaScript error: , line 0: uncaught exception: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsINavHistoryService.executeQueries]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://browser/content/places/tree.xml :: load :: line 97"  data: no]

Comment 5

[(not reading, please use [e-mail] instead)]

martijn, could you have run an old build (M7 or earlier) on this profile, or for some reason had a corrupt places.sqlite?

See https://bugzilla.mozilla.org/show_bug.cgi?id=407296#c15

Comment 6

[Marco Bonardo [:mak]]

marking as INVALID since caused by previous bugs (now fixed) that allowed the user to corrupt their db duplicating and deleting roots in the Library.

please reopen if comment #4 error is still visible/reproduceable

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv