Closed Bug 406675 Opened 15 years ago Closed 15 years ago

"ASSERTION: bad index" in nsTextFragment.h with RLE

Categories

(Core :: Layout: Text and Fonts, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: smontagu)

References

Details

(Keywords: assertion, testcase, Whiteboard: [sg:moderate?])

Attachments

(2 files, 1 obsolete file)

Attached file testcase
Loading the testcase triggers:

###!!! ASSERTION: bad index: 'PRUint32(aIndex) < mState.mLength', file /Users/jruderman/trunk/mozilla/layout/base/../../content/base/src/nsTextFragment.h, line 184

Filing as security-sensitive because previous bugs involving this assertion were [sg:moderate].  (Bug 368860 and bug 385426.)
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
Assignee: nobody → smontagu
OS: Mac OS X → All
Hardware: PC → All
Whiteboard: [sg:moderate?]
Attachment #291753 - Attachment is obsolete: true
Attachment #291762 - Flags: superreview?(roc)
Attachment #291762 - Flags: review?
Attachment #291753 - Flags: superreview?(roc)
Attachment #291753 - Flags: review?
Comment on attachment 291753 [details] [diff] [review]
Do AdjustOffsetsForBidi on the original frame before creating a bidi continuation

+DIRS += reftests
+

I don't think you want this here.
Attachment #291753 - Flags: superreview+
Attachment #291753 - Flags: review+
Sorry, I didn't save changes to the patch before attaching it. I also meant to ask review from Uri, but the request failed because he wasn't cc-ed
Comment on attachment 291762 [details] [diff] [review]
The correct patch

transferring sr=roc
Attachment #291762 - Flags: superreview?(roc)
Attachment #291762 - Flags: superreview+
Attachment #291762 - Flags: review?(uriber)
Attachment #291762 - Flags: review?
Comment on attachment 291762 [details] [diff] [review]
The correct patch

Looks OK to me. sorry for the delay.
Attachment #291762 - Flags: review?(uriber) → review+
Checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
No assertions on the 1.8 branch.
Group: security
Flags: wanted1.8.1.x-
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: layout.bidi → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.