Modern Navigator (large/small) button icon graphics need to be converted to a .PNG and the background made alpha transparent

RESOLVED FIXED in seamonkey2.0a1

Status

--
enhancement
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: philip.chee, Assigned: kairo)

Tracking

Trunk
seamonkey2.0a1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments, 7 obsolete attachments)

20.73 KB, patch
neil
: review+
Details | Diff | Splinter Review
35.33 KB, image/png
neil
: review+
Details
10.27 KB, image/png
neil
: review+
Details
8.32 KB, image/png
neil
: review+
Details
2.33 KB, image/png
neil
: review+
Details
2.30 KB, image/png
neil
: review+
Details
(Reporter)

Description

11 years ago
Created attachment 291434 [details]
suite/themes/modern/navigator/icons/btn1.gif

See Bug 394288 Comment #13. When customizable toolbars is enabled in Navigator, the graphics for the modern navigation buttons look out of place mostly because they use a hard-coded gradient as the background. Currently I am using a variant from the modern aluminium theme but I think we might need to check the copyrights and licensing on this if the SeaMonkey council agrees to check this in.

Alternatively someone with more graphic skills than I do can proceed to convert the existing modern btn1.gif into a .png with an alpha transparent background. I /think/ there is a subtle drop shadow in this that isn't in the modern aluminium theme.
(Assignee)

Comment 1

11 years ago
Created attachment 291455 [details]
try 1: transparent, missing highlight

You can try this one, it's missing the highlight on the left, but everything else should be fine, I hope.
(Assignee)

Comment 2

11 years ago
Created attachment 291460 [details]
try 2: transparent, including highlight

Actually, try this one, I have added highlight as well now. It's not 100% identical to the original one, but it should be close enough that people don't notice.
Attachment #291455 - Attachment is obsolete: true

Comment 3

11 years ago
Created attachment 291634 [details]
Enhanced image difference error

This is an enhancement of the difference between btn1.gif and pasting this image on a background of prtb-bg-noline.gif - the worst actual difference any given pixel has is 16 in red channel.

Comment 4

11 years ago
Created attachment 291635 [details]
Pixels that exist but aren't displayed

These are pixels that have nonzero RGB values but 100% transparency.
(Excepting the left block "actual" colour for the pixels is #DCE2EA)
I mention them because they look odd in my image editor's edit mode.
(Reporter)

Comment 5

11 years ago
Created attachment 291638 [details]
Screenshot of KaiRo's btn1.png in action

(In reply to Comment #2)

> Created an attachment (id=291460) [details]
> try 2: transparent, including highlight

I forgot to mention that currently in modern, the home button graphics live in  separate .GIFs in /suite/themes/modern/help.home*.gif . Modern Aluminium adds the home button(s) to btn1.png but I am not currently using that row in my patch.
(Assignee)

Comment 6

11 years ago
(In reply to comment #3)
> the worst actual difference any given pixel has is 16 in red channel.

Is this acceptable?

(In reply to comment #4)
> These are pixels that have nonzero RGB values but 100% transparency.

I can correct those easily and will do so in a followup that includes the home button in this image.

Comment 7

11 years ago
(In reply to comment #6)
>(In reply to comment #3)
>>the worst actual difference any given pixel has is 16 in red channel.
>Is this acceptable?
Converting the resulting image back to a .GIF more than doubles the error ;-)
(Assignee)

Comment 8

11 years ago
Created attachment 292401 [details]
try 2: transparent, highlight, add home

Here's an image that includes the home button and I hope it should have the issue with the colored transparent pixels fixed.
Assignee: guifeatures → kairo
Attachment #291460 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #292401 - Flags: review?(neil)

Comment 9

11 years ago
(In reply to comment #5)
>I forgot to mention that currently in modern, the home button graphics live in 
>separate .GIFs in /suite/themes/modern/help.home*.gif . Modern Aluminium adds
>the home button(s) to btn1.png but I am not currently using that row in my patch.
Interestingly Classic has reload in navigator and the other five in communicator.

Updated

11 years ago
Attachment #292401 - Flags: review?(neil) → review+
(Reporter)

Updated

11 years ago
Summary: suite/themes/modern/navigator/icons/btn1.gif needs to be converted to a .PNG and the background made alpha transparent → Modern Navigator (large/small) button icon graphics need to be converted to a .PNG and the background made alpha transparent
(Assignee)

Comment 10

11 years ago
Created attachment 293506 [details] [diff] [review]
patch: packaging/CSS changes

OK, I completely rework this now, so that all images that are used across multiple components are in communicator and only the browser-specific reload image stays in navigator (this mirrors what the default theme has), and I also included the print button, as well as small images.
The small images make it necessary to use one common style for home across help and browser windows, so I went for using the style we have in help also for the small image. Imagery follows.
Attachment #291434 - Attachment is obsolete: true
Attachment #291634 - Attachment is obsolete: true
Attachment #291635 - Attachment is obsolete: true
Attachment #291638 - Attachment is obsolete: true
Attachment #292401 - Attachment is obsolete: true
Attachment #293506 - Flags: superreview?(neil)
Attachment #293506 - Flags: review?(neil)
(Assignee)

Comment 11

11 years ago
Created attachment 293508 [details]
mozilla/suite/themes/modern/communicator/icons/common.png
Attachment #293508 - Flags: review?(neil)
(Assignee)

Comment 12

11 years ago
Created attachment 293509 [details]
mozilla/suite/themes/modern/communicator/icons/common-small.png
Attachment #293509 - Flags: review?(neil)
(Assignee)

Comment 13

11 years ago
Created attachment 293510 [details]
mozilla/suite/themes/modern/navigator/icons/browser.png
Attachment #293510 - Flags: review?(neil)
(Assignee)

Comment 14

11 years ago
Created attachment 293512 [details]
mozilla/suite/themes/modern/navigator/icons/browser-small.png
Attachment #293512 - Flags: review?(neil)
(Assignee)

Comment 15

11 years ago
Created attachment 293514 [details]
mozilla/suite/themes/modern/navigator/icons/windowcontrols.png

I did split this windowcontrols.png off the small icons as they are different size anyways and not used for normal small toolbars, only for fullscreen.
Attachment #293514 - Flags: review?(neil)

Comment 16

11 years ago
Comment on attachment 293506 [details] [diff] [review]
patch: packaging/CSS changes

> /* temporary - still don't have small print icons */
> #print-button[toolbarmode="small"] {
Not true ;-) r+sr=me with this fixed.

> #close-button[disabled="true"] {
>-  -moz-image-region: rect(108px  60px 124px 45px) !important;
>-} 
>+  -moz-image-region: rect(32px  60px 48px 45px) !important;
>+}
Might as well kill the double space ^
Attachment #293506 - Flags: superreview?(neil)
Attachment #293506 - Flags: superreview+
Attachment #293506 - Flags: review?(neil)
Attachment #293506 - Flags: review+

Updated

11 years ago
Attachment #293508 - Flags: review?(neil) → review+

Updated

11 years ago
Attachment #293509 - Flags: review?(neil) → review+

Updated

11 years ago
Attachment #293510 - Flags: review?(neil) → review+

Updated

11 years ago
Attachment #293512 - Flags: review?(neil) → review+

Updated

11 years ago
Attachment #293514 - Flags: review?(neil) → review+
(Assignee)

Comment 17

11 years ago
Checked in with those nits fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Target Milestone: --- → seamonkey2.0alpha

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.