406852 - leak docshell on vanguard login page

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Steps to reproduce:
 1. set the following environment variables:
    NSPR_LOG_MODULES=DOMLeak:5,DocumentLeak:5,nsDocShellLeak:5
    NSPR_LOG_FILE=nspr.log
 2. run Firefox with https://flagship3.vanguard.com/VGApp/hnw/MyHome as the
    command-line URL argument
 3. wait for the login page to load
 4. close the window

Expected results: no leaks

Actual results: A bunch of leaks, including a docshell leak:
Leaked docshell at address 9083d98.
 ... which loaded URI "https://personal.vanguard.com/passmark/flash/pmfso.swf?sendUrl=%2FVGApp%2Fhnw%2Fhnwnesc%2FPMLogin%3Faction%3Dfso".


(This is the first easily reproducable docshell leak I've found for quite a while; leaking a docshell implies leaking lots of other stuff inside it, generally including documents and windows.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The docshell is leaked from an nsFrameLoader's mDocShell.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The frame loader is leaked from an nsObjectLoadingContent's mFrameLoader.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This is totally mine!

Comment 5

[Mike Schroepfer]

Jonas/DBaron - what was the cause of this leak (recent or old) and does it portend any other leaks?

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This is a regression from the recent nsDocument::Destroy fix. So it's not something that'll fix any other bugs that we have on file.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in. Thanks david for finding this and pointing in the right direction!