Closed
Bug 406852
Opened 17 years ago
Closed 17 years ago
leak docshell on vanguard login page
Categories
(Core Graveyard :: Plug-ins, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: sicking)
References
()
Details
(Keywords: memory-leak, regression)
Attachments
(1 file)
3.12 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
Steps to reproduce:
1. set the following environment variables:
NSPR_LOG_MODULES=DOMLeak:5,DocumentLeak:5,nsDocShellLeak:5
NSPR_LOG_FILE=nspr.log
2. run Firefox with https://flagship3.vanguard.com/VGApp/hnw/MyHome as the
command-line URL argument
3. wait for the login page to load
4. close the window
Expected results: no leaks
Actual results: A bunch of leaks, including a docshell leak:
Leaked docshell at address 9083d98.
... which loaded URI "https://personal.vanguard.com/passmark/flash/pmfso.swf?sendUrl=%2FVGApp%2Fhnw%2Fhnwnesc%2FPMLogin%3Faction%3Dfso".
(This is the first easily reproducable docshell leak I've found for quite a while; leaking a docshell implies leaking lots of other stuff inside it, generally including documents and windows.)
Flags: blocking1.9?
Reporter | ||
Comment 1•17 years ago
|
||
The docshell is leaked from an nsFrameLoader's mDocShell.
Reporter | ||
Comment 2•17 years ago
|
||
The frame loader is leaked from an nsObjectLoadingContent's mFrameLoader.
Assignee | ||
Comment 3•17 years ago
|
||
Attachment #291594 -
Flags: superreview?
Attachment #291594 -
Flags: review?(peterv)
Assignee | ||
Updated•17 years ago
|
Attachment #291594 -
Flags: superreview? → superreview?(peterv)
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.9? → blocking1.9+
Priority: -- → P1
Updated•17 years ago
|
Attachment #291594 -
Flags: superreview?(peterv)
Attachment #291594 -
Flags: superreview+
Attachment #291594 -
Flags: review?(peterv)
Attachment #291594 -
Flags: review+
Comment 5•17 years ago
|
||
Jonas/DBaron - what was the cause of this leak (recent or old) and does it portend any other leaks?
Assignee | ||
Comment 6•17 years ago
|
||
This is a regression from the recent nsDocument::Destroy fix. So it's not something that'll fix any other bugs that we have on file.
Blocks: 348156
Assignee | ||
Comment 7•17 years ago
|
||
Checked in. Thanks david for finding this and pointing in the right direction!
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Keywords: regression
Updated•17 years ago
|
Flags: in-testsuite?
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•