Closed Bug 406860 Opened 16 years ago Closed 10 years ago

reduce Ts / Txul by applying the "hidden" trick to customizeToolbarSheetPopup

Categories

(Firefox :: General, defect, P4)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 28

People

(Reporter: moco, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [Australis:M8][qa-])

Attachments

(1 file)

Patch v1
1.56 KB, patch
jaws
: review+
Details | Diff | Splinter Review 
reduce Ts / Txul by applying the "hidden" trick to customizeToolbarSheetPopup

see bug #405235 and bug #402668 for more details.
Flags: blocking-firefox3?
Nice to have, not going to make this a hard blocker though.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Priority: -- → P4
Target Milestone: --- → Firefox 3 M11
Even easier, since Australis will move customization outside of a popup, we can now remove the customizeToolbarSheetPopup from /browser altogether :)
Assignee: nobody → jaws
Blocks: australis-cust
Status: NEW → ASSIGNED
Whiteboard: [Australis:M?]
Target Milestone: Firefox 3 beta3 → ---
Attached patch Patch v1 — — Splinter Review 
All of the sheet handling was removed for the Australis customization stuff. This sheet panel node is just a holdover that probably should have been removed at the same time.
Assignee: jaws → mconley
Attachment #766838 - Flags: review?(jaws)
Comment on attachment 766838 [details] [diff] [review]
Patch v1

Review of attachment 766838 [details] [diff] [review]:
-----------------------------------------------------------------

BAM!
Attachment #766838 - Flags: review?(jaws) → review+
Thanks!

https://hg.mozilla.org/projects/ux/rev/9695fd3df674
Whiteboard: [Australis:M?] → [Australis:M8][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/9695fd3df674
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][fixed-in-ux] → [Australis:M8]
Target Milestone: --- → Firefox 28
Whiteboard: [Australis:M8] → [Australis:M8][qa-]
You need to log in before you can comment on or make changes to this bug.