Closed
Bug 406871
Opened 17 years ago
Closed 17 years ago
Getting 32x32 px icons using -moz-icon
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: micmon, Assigned: reed)
Details
Attachments
(1 file, 1 obsolete file)
|
1.63 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
Using moz-icon, we can currently get native icons in the sizes 16x16 (menu), 22x22 (button), 24x24 (toolbar) and 48x48 (dialog).
Missing is gtk size for 32x32, which is called dnd. This size would be helpful for theming preferences-like dialogs as well some other places.
|
Assignee | |
Updated•17 years ago
|
Component: Widget: Gtk → ImageLib
QA Contact: gtk → imagelib
|
|
Assignee | |
Comment 1•17 years ago
|
||
I think it's as simple as this.
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #291549 -
Flags: superreview?(cbiesinger)
Attachment #291549 -
Flags: review?(cbiesinger)
|
||
Updated•17 years ago
|
Attachment #291549 -
Flags: superreview?(cbiesinger)
Attachment #291549 -
Flags: superreview+
Attachment #291549 -
Flags: review?(cbiesinger)
Attachment #291549 -
Flags: review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Comment on attachment 291549 [details] [diff] [review]
patch - v1
Simple size-type addition.
Attachment #291549 -
Flags: approval1.9?
|
|
Assignee | |
Comment 3•17 years ago
|
||
Ventron noticed I missed a place.Thanks, Ventron!
Attachment #291549 -
Attachment is obsolete: true
Attachment #291553 -
Flags: superreview?(cbiesinger)
Attachment #291553 -
Flags: review?(cbiesinger)
Attachment #291549 -
Flags: approval1.9?
|
|
||
Updated•17 years ago
|
Attachment #291553 -
Flags: superreview?(cbiesinger)
Attachment #291553 -
Flags: superreview+
Attachment #291553 -
Flags: review?(cbiesinger)
Attachment #291553 -
Flags: review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Comment on attachment 291553 [details] [diff] [review]
patch - v2
Try this again.
Attachment #291553 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #291553 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Checking in modules/libpr0n/decoders/icon/nsIconURI.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/nsIconURI.cpp,v <-- nsIconURI.cpp
new revision: 1.30; previous revision: 1.29
done
Checking in modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/gtk/nsIconChannel.cpp,v <-- nsIconChannel.cpp
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in
before you can comment on or make changes to this bug.
Description
•