406916 - nsXULElement::AfterSetAttr notifies when it shouldn't

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

nsXULElement::AfterSetAttr seems to have the fllowing code:

        // handle :read-only/:read-write
        nsIDocument *document = GetCurrentDoc();
        if (aName == nsGkAtoms::readonly && document) {
            mozAutoDocUpdate upd(document, UPDATE_CONTENT_STATE, PR_TRUE);
            document->ContentStatesChanged(this, nsnull,
                                           NS_EVENT_STATE_MOZ_READONLY |
                                           NS_EVENT_STATE_MOZ_READWRITE);
        }

I'm a little confused by why it's needed, since nsGenericElement::SetAttr handles state changes happening during the attr set. 

If it _is_ needed, should it really be notifying even if aNotify is false? 

Note that removing the "readonly" attribute is not handled, by the way...

Comment 1

[Mike Schroepfer]

bz can you suggest a priority?

Comment 2

[Boris Zbarsky [:bzbarsky]]

I'd say P3.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Peter, you added this code. Actually, the fact that it notifies when aNotify is false could actually probably cause exploitable crashes, so upping priority of that part.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1

Yeah, that seems like a mistake.