406947 - Improve quit handling ctrl+q

Status: NEW

(Other Applications :: ChatZilla, enhancement)

Description

[:Gijs (he/him)]

There are a couple of things I think we should be doing and aren't doing currently:

1. Listen for appropriate quit events so we can yell at the user if they use File > Quit from Firefox, and are still connected in ChatZilla. Right now we will exit quietly. We need to be careful here as SeaMonkey and Firefox have some subtly different ways of notifying and/or checking windows for being OK with quitting.

2. On XULRunner, /quit should close all windows and quit properly (using the confusingly named nsIAppStartup or whatever it was). Right now it won't close the join channel or preferences dialog. We should also broadcast the same listener Firefox and co. use so that if anyone ever writes extensions for our code, they can do the same kinds of things. :-)

(the fact that these listener things overlap is the reason I filed only one bug for this issue. I think if we're smart, we can tackle both in one patch/algorithm/whatever)

Comment 1

[:Hb]

People using bouncers to stay connected to one or more channels even when their PC is offline might want another behaviour when quitting Chatzilla.

In these cases the channel windows must not be closed before the connection to the bouncer server is disconnected. Otherwise the bouncer misinterprets the closing and closes his connection to the original channel too.

Comment 2

[:Gijs (he/him)]

(In reply to comment #1)
> People using bouncers to stay connected to one or more channels even when their
> PC is offline might want another behaviour when quitting Chatzilla.
> 
> In these cases the channel windows must not be closed before the connection to
> the bouncer server is disconnected. Otherwise the bouncer misinterprets the
> closing and closes his connection to the original channel too.

We never explicitly leave channels before disconnecting without the user asking us to, and that won't change. So I would assume that would be fine.

Comment 3

[:Hb]

As Gijs said the current behaviour is fine. Chatzilla doesn't interfere with bouncers on closing.

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to comment #0)
> There are a couple of things I think we should be doing and aren't doing
> currently:
> 
> 1. Listen for appropriate quit events so we can yell at the user if they use
> File > Quit from Firefox, and are still connected in ChatZilla. Right now we
> will exit quietly. We need to be careful here as SeaMonkey and Firefox have
> some subtly different ways of notifying and/or checking windows for being OK
> with quitting.

I encountered this for the first time, I think I accidentally hit ctrl+Q in SM (1.1.4). I then canceled the close but cz quietly ended.  

I could not reproduce. Ratty says he sees this randomly.