407082 - remove redundant code and UI for first popup information

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Teune van Steeg]

Currently popup blocking is off by default and when a popup window is opened for the first time, the users will be notified that there is a possibility to disable popup blocking, and where you can turn it on. The notification also says that you will be informed about blocked popups in the status bar.

With bug 393120 popup blocking will be on by default. And when a user turns off popup blocking he/she will already be aware that it is available when his/her first popup window opens. This means there is no use for the notification anymore, and that the corresponding code/UI can be removed.

Comment 1

[Stefan [:stefanh]]

Remove the "About Popup Blocking" menuitem in Tools --> Popup Manager as well?

Comment 2

[[e-mail]]

Yes, that can go too.

Comment 3

[Stefan [:stefanh]]

Attachment: Remove code/ui etc

This should be it.

1) Removes aboutPopups.xul, aboutPopups.dtd and about-popups.gif
2) Removes redundant js/xul, also the "About Popup Blocking" menuitem

Comment 4

[Stefan [:stefanh]]

Removing suite/common/permissions/aboutPopups.xul;
/cvsroot/mozilla/suite/common/permissions/aboutPopups.xul,v  <--  aboutPopups.xul
new revision: delete; previous revision: 1.8
done
Checking in suite/common/permissions/permissionsNavigatorOverlay.xul;
/cvsroot/mozilla/suite/common/permissions/permissionsNavigatorOverlay.xul,v  <--  permissionsNavigatorOverlay.xul
new revision: 1.34; previous revision: 1.33
done
Removing suite/locales/en-US/chrome/common/permissions/aboutPopups.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/common/permissions/aboutPopups.dtd,v  <--  aboutPopups.dtd
new revision: delete; previous revision: 1.1
done
Checking in suite/locales/en-US/chrome/common/permissions/permissionsNavigatorOverlay.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/common/permissions/permissionsNavigatorOverlay.dtd,v  <--  permissionsNavigatorOverlay.dtd
new revision: 1.10; previous revision: 1.9
done
Checking in suite/browser/browser-prefs.js;
/cvsroot/mozilla/suite/browser/browser-prefs.js,v  <--  browser-prefs.js
new revision: 1.79; previous revision: 1.78
done
Checking in suite/browser/navigator.js;
/cvsroot/mozilla/suite/browser/navigator.js,v  <--  navigator.js
new revision: 1.618; previous revision: 1.617
done
Checking in suite/common/jar.mn;
/cvsroot/mozilla/suite/common/jar.mn,v  <--  jar.mn
new revision: 1.38; previous revision: 1.37
done
Checking in suite/locales/jar.mn;
/cvsroot/mozilla/suite/locales/jar.mn,v  <--  jar.mn
new revision: 1.28; previous revision: 1.27
done
Checking in suite/themes/classic/jar.mn;
/cvsroot/mozilla/suite/themes/classic/jar.mn,v  <--  jar.mn
new revision: 1.172; previous revision: 1.171
done
Checking in suite/themes/classic/navigator/navigator.css;
/cvsroot/mozilla/suite/themes/classic/navigator/navigator.css,v  <--  navigator.css
new revision: 1.41; previous revision: 1.40
done
Checking in suite/themes/modern/jar.mn;
/cvsroot/mozilla/suite/themes/modern/jar.mn,v  <--  jar.mn
new revision: 1.181; previous revision: 1.180
done
Checking in suite/themes/modern/navigator/navigator.css;
/cvsroot/mozilla/suite/themes/modern/navigator/navigator.css,v  <--  navigator.css
new revision: 1.99; previous revision: 1.98
done
Removing suite/themes/classic/navigator/icons/about-popups.gif;
/cvsroot/mozilla/suite/themes/classic/navigator/icons/about-popups.gif,v  <--  about-popups.gif
new revision: delete; previous revision: 1.1
done
Removing suite/themes/modern/navigator/icons/about-popups.gif;
/cvsroot/mozilla/suite/themes/modern/navigator/icons/about-popups.gif,v  <--  about-popups.gif
new revision: delete; previous revision: 1.1
done