407086 - remove some unused unconstrained width handling code

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While I was reviewing bug 405577, I found a bunch of unused code that should have been removed during the reflow branch landing -- mostly dealing with unconstrained width handling, but also a little bit left over from maxelementsize calculation (that could have been removed when I changed maxelementsize to maxelementwidth).

Patches to follow, with explanations.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: remove nsHTMLReflowState::mRightEdge

Remove an unused member variable from nsHTMLReflowState.  Should have been removed even before bug 192767, which removed the last nontrivial setter.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: remove code to handle nsLineLayout::mRightEdge being NS_UNCONSTRAINEDSIZE

This should have been done on the reflow branch.  It makes nsFirstLetterFrame pass through a real available width to BeginLineReflow; other than that it removes unconstrained width handling code.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: remove the height output from nsLineLayout::EndSpan

I noticed this while writing the previous patch, which this applies on top of.  This should have been done along with bug 186953.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 291800 [details] [diff] [review]
remove code to handle nsLineLayout::mRightEdge being NS_UNCONSTRAINEDSIZE

+  availableWidth = PR_MAX(0, availableWidth);

This conflicts with the patch we just landed, but no worries...

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 291801 [details] [diff] [review]
remove the height output from nsLineLayout::EndSpan

Might as well make EndSpan return the width directly if you're doing this

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: remove the height output from nsLineLayout::EndSpan

Good idea.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

All three patches checked in.