407138 - Improved Bulgarian [bg] translation for Firefox 2.0.0.x

Status: RESOLVED FIXED

(Mozilla Localizations :: bg / Bulgarian, defect)

Description

[Ognyan Kulev]

Attachment: Improved Bulgarian [bg] translation of Firefox 2

A contributor (Zlatko Popov) made many improvements in existing Bulgarian [bg]  translation of Firefox 2. I would like to get them in.

Comment 1

[Axel Hecht [:Pike]]

One thing I found is an additional position for one search engine, wikipedia, one two.

I guess Mic has comments and questions on that, https://bugzilla.mozilla.org/attachment.cgi?id=291866&action=diff#browser/chrome/browser-region/region.properties_sec1

Comment 2

[Axel Hecht [:Pike]]

Rob, can you comment on https://bugzilla.mozilla.org/attachment.cgi?id=291866&action=diff#browser/installer/mui.properties_sec1 ?

It's translating the $_CLICK in there, and I have no idea what that does, and if there are side effects when doing that, or if it's just plain wrong.

Comment 3

[Ognyan Kulev]

(In reply to comment #1)
> One thing I found is an additional position for one search engine, wikipedia,
> one two.

This is undesirable side-effect of using old automated tools for converting from PO to dtd/properties. Usually I remove that manually but this time I forgot.

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> Rob, can you comment on
> https://bugzilla.mozilla.org/attachment.cgi?id=291866&action=diff#browser/installer/mui.properties_sec1
> ?
> 
> It's translating the $_CLICK in there, and I have no idea what that does, and
> if there are side effects when doing that, or if it's just plain wrong.
The wizard needs to state Click Next, Click Install, etc. based on what the next wizard page is. Should be no side affects as long as the strings are provided and it should be used.

Comment 5

[Ognyan Kulev]

Attachment: Improved Bulgarian [bg] translation of Firefox 2

The same patch with removed trademark change (adding Wikipedia.bg).

The reason for the missing $_CLICK is that it's provided as integrated text in message. It sounds better in Bulgarian this way.

Comment 6

[Robert Strong (they/them - no direct email)]

(In reply to comment #5)
>...
> The reason for the missing $_CLICK is that it's provided as integrated text in
> message. It sounds better in Bulgarian this way.
What is the string used for $_CLICK in Bulgarian?

Comment 7

[Ognyan Kulev]

(In reply to comment #6)
> What is the string used for $_CLICK in Bulgarian?

The last sentence "Ако ги приемате, изберете първата опция и натиснете „Напред“." translates to "If you accept [the terms of the agreement], choose the first option and press Next.".

Comment 8

[Robert Strong (they/them - no direct email)]

Per the patch, that appears to be the new string without using $_CLICK and not what the string is when using $_CLICK.

Comment 9

[Ognyan Kulev]

(All English text below is translated from Bulgarian translation and so may differ a bit from original.)

$_CLICK is "Click Next to continue". So current translation is "...You must accept the aggreement to install $(^NameDA). Click Next to continue.". Proposed translation is "...If you accept them [the terms of the agreement], [then] choose the first option and click Next.". If you think it's too much deviation, I'll change the patch to closely resemble original text.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 294197 [details] [diff] [review]
Improved Bulgarian [bg] translation of Firefox 2

[bg] approval for branch landing granted. Please use the fixed1.8.1.12 and verified1.8.1.12 keywords to track landing and testing.

Given the size of the patch, I assume that there will be some extensive testing on the nightlies. Note that the tree closes on the 18th, if all goes as planned, too, http://wiki.mozilla.org/Releases/Firefox_2.0.0.12.

Comment 11

[Ognyan Kulev]

Committed and marked in keywords as fixed1.8.1.12. I wasn't sure if I should mark it as RESOLVED FIXED too and I decided to leave it as NEW.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

Looks like this is a branch-only bug that's already fixed. -> FIXED