407166 - Various regressions from bug 398807

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P3)

Description

[Simon Bünzli]

(From bug 398807 comment #34)
> Seems that for the first two tweaks, I've missed one potential issue: once one
> of the values .disallow, .xultab, .hidden, .sidebar, .extdata, .screenX and
> .screenY has been set, it won't be unset anymore, leading to regressions such
> as bug 400873.
> 
> If both tweaks have indeed led to performance improvements, we'd at least have
> to add code for unsetting all of the above properties, e.g.:
> 
>     if (sidebar)
>       ...
> +   else if (winData.sidebar)
> +     delete winData.sidebar;

Comment 1

[Simon Bünzli]

Attachment: fix

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 291900 [details] [diff] [review]
fix

r=me, thanks

Comment 3

[Reed Loden [:reed]]

Comment on attachment 291900 [details] [diff] [review]
fix

This fixes multiple regressions from bug 398807, including blocker bug 400873. Could we get this in for b2?

Comment 4

[Mike Schroepfer]

Comment on attachment 291900 [details] [diff] [review]
fix

This can wait till after b2

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 291900 [details] [diff] [review]
fix

a=mconnor on behalf of drivers for 1.9

Comment 6

[Reed Loden [:reed]]

Checking in browser/components/sessionstore/src/nsSessionStore.js;
/cvsroot/mozilla/browser/components/sessionstore/src/nsSessionStore.js,v  <--  nsSessionStore.js
new revision: 1.85; previous revision: 1.84
done