407193 - Restore animateFadeIn behavior for Mac prefpanes (revert fix for bug 394881)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[:Gavin Sharp [email: [e-mail]]]

Now that bug 355177 is fixed, I'm told that we should be able to undo the changes made in bug 394881 and re-enable animateFadeIn on the Mac without re-introducing bug 377060.

Comment 1

[Florian Quèze [:florian]]

Attachment: patch v1

The patch only changes the default value of the pref for Mac.

Keeping the min-height value doesn't prevent the animation from working, and removing it would sort of break the window when the animation is disabled from about:config.

Comment 2

[Shawn Wilsher :sdwilsh]

So, you are saying that the animation works just fine with a min-height value (as in, the boxes are of varying heights)?

Comment 3

[Florian Quèze [:florian]]

Yeah. The min-height value seems to be ignored when we activate the animation.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 292165 [details] [diff] [review]
patch v1

r=mconnor

Comment 5

[Florian Quèze [:florian]]

Checking in browser/app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.240; previous revision: 1.239
done
Checking in toolkit/content/widgets/preferences.xml;
/cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v  <--  preferences.xml
new revision: 1.74; previous revision: 1.73
done