407194 - Restore old session is leaking nsGlobalWindows

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Carsten Book [:Tomcat]]

Attachment: leak log

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b2pre) Gecko/2007120610 Minefield/3.0b2pre

Session restore leaks, see leaklog.

Steps to reproduce:
3 Tabs Open 
http://graphs.mozilla.org/
https://bugzilla.mozilla.org/attachment.cgi?id=291700
https://litmus.mozilla.org/
Killed Firefox (via top)
restarted Firefox
choosed to restore my old session
Leak

nsStringStats
 => mAllocCount:          17849
 => mReallocCount:         3907
 => mFreeCount:           14292  --  LEAKED 3557 !!!
 => mShareCount:          17249
 => mAdoptCount:           2473
 => mAdoptFreeCount:       2466  --  LEAKED 7 !!!

Comment 1

[Carsten Book [:Tomcat]]

Attachment: new leak log

still leak with the same steps to reproduce on Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b3pre) Gecko/2008012104 Minefield/3.0b3pre - this build has the patch from bug 412491 included

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Peter, do you have time to look at this? This looks pretty important since we're leaking a lot and restoring sessions seems like a pretty common task

Comment 3

[Peter Van der Beken [:peterv]]

I can't reproduce this on an OS X build from today.

Comment 4

[Carsten Book [:Tomcat]]

not anymore reproducible on mac/linux also after various crashs and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2008012923 Firefox/3.0b3pre

-> fixed

Comment 5

[Carsten Book [:Tomcat]]

verified fixed with latest Debug Build and also per comment #4

--> Verified fixed