Last Comment Bug 407221 - Change l10n notes in places.properties
: Change l10n notes in places.properties
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Location Bar (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 13
Assigned To: Mark Capella [:capella]
:
Mentors:
https://bugzilla.mozilla.org/attachme...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-06 15:44 PST by Kadir Topal [:atopal]
Modified: 2012-02-24 02:51 PST (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Change notes in properties file (1.45 KB, patch)
2012-02-08 14:23 PST, Mark Capella [:capella]
no flags Details | Diff | Splinter Review
Bug fix with "Noun" wording... (1.46 KB, patch)
2012-02-10 05:24 PST, Mark Capella [:capella]
no flags Details | Diff | Splinter Review
Bug fix with "Noun / result type" wording... (1.47 KB, patch)
2012-02-13 01:04 PST, Mark Capella [:capella]
no flags Details | Diff | Splinter Review
Small patch (1.47 KB, patch)
2012-02-18 08:08 PST, Mark Capella [:capella]
no flags Details | Diff | Splinter Review
Small patch v2 (1.48 KB, patch)
2012-02-20 08:06 PST, Mark Capella [:capella]
mak77: review+
Details | Diff | Splinter Review
Small patch v3 (1.48 KB, patch)
2012-02-20 08:39 PST, Mark Capella [:capella]
mak77: review+
Details | Diff | Splinter Review

Description Kadir Topal [:atopal] 2007-12-06 15:44:58 PST
The notes for localizers in places.properties from bug 406355 are unfortunately not of much help, another wording should be used.
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2007-12-06 15:52:12 PST
Perhaps something like: "Used to describe the location bar autocomplete icons for users with screen readers"? Is that clearer, Abdulkadir?
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2007-12-06 15:53:52 PST
Although perhaps that's not entirely accurate, since the descriptions might not necessarily map to icons in the popup. Seth might be able to come up with something better.
Comment 3 Kadir Topal [:atopal] 2007-12-06 16:02:35 PST
Would definitely be better, it's not so important that the description is 100% accurate, in this case it would be enough to just know, whether the labels are used as nouns or verbs.
Comment 4 Mark Capella [:capella] 2012-02-08 14:23:44 PST
Created attachment 595536 [details] [diff] [review]
Change notes in properties file


   I'm reviewing the [Good first bugs] and wonder if this old item is resolvable with the (simple) attached patch ...
Comment 5 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-08 14:41:18 PST
Comment on attachment 595536 [details] [diff] [review]
Change notes in properties file

Review of attachment 595536 [details] [diff] [review]:
-----------------------------------------------------------------

based on the above feedback, I'd probably do "Noun used to describe..."

Btw, tentatively asking feedback to Kadir
Comment 6 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-08 14:42:26 PST
So, maybe "Noun used to describe the location bar autocomplete result type to users with screen readers"
Comment 7 Mark Capella [:capella] 2012-02-10 05:24:13 PST
Created attachment 596023 [details] [diff] [review]
Bug fix with "Noun" wording...


   Bug fix with "Noun" wording...
Comment 8 Mark Capella [:capella] 2012-02-13 01:04:27 PST
Created attachment 596615 [details] [diff] [review]
Bug fix with "Noun / result type" wording...
Comment 9 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-15 07:48:57 PST
If you don't get an answer in a couple days, feel free to flag me for review.
Comment 10 Mark Capella [:capella] 2012-02-15 08:01:45 PST
mak: thanks for the fallback, will wait for a few
Comment 11 Mark Capella [:capella] 2012-02-18 08:08:55 PST
Created attachment 598539 [details] [diff] [review]
Small patch


   As per previous comment ...
Comment 12 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-20 07:48:42 PST
Comment on attachment 598539 [details] [diff] [review]
Small patch

Review of attachment 598539 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/places/places.properties
@@ +79,4 @@
>  # See createResultLabel() in urlbarBindings.xml 
>  tagResultLabel=Tag
>  # LOCALIZATION NOTE (bookmarkResultLabel) :
> +# Noun used to describe the location bar autocomplete result type to users with screen readers

I'd just ask you to go on a new line so that the text is limited to 80 chars
Comment 13 Mark Capella [:capella] 2012-02-20 08:06:14 PST
Created attachment 598882 [details] [diff] [review]
Small patch v2

Two lines ... <80 chars
Comment 14 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-20 08:28:56 PST
Comment on attachment 598882 [details] [diff] [review]
Small patch v2

Review of attachment 598882 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/places/places.properties
@@ +80,5 @@
>  # See createResultLabel() in urlbarBindings.xml 
>  tagResultLabel=Tag
>  # LOCALIZATION NOTE (bookmarkResultLabel) :
> +# Noun used to describe the location bar
> +# Autocomplete result type to users with screen readers

why did Autocomplete become uppercase? maybe it's just your text editor's fault, please fix it.

I'd probably break after type, but that's not that much important.
Comment 15 Mark Capella [:capella] 2012-02-20 08:39:45 PST
Created attachment 598891 [details] [diff] [review]
Small patch v3


   I'll get there yet!  :-)
Comment 16 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-20 08:44:58 PST
Comment on attachment 598891 [details] [diff] [review]
Small patch v3

yes, you did it!
Comment 17 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-02-21 02:23:50 PST
autoland currently only works on try, is that your purpose?
Comment 18 Mark Capella [:capella] 2012-02-21 02:27:22 PST
Yes, but it doesn't actually seem to be working. I realize that TRYing a comment change is trivial, but I was testing out the functionality for future.

(I really need to pursue my L1 access).
Comment 19 Mozilla RelEng Bot 2012-02-21 06:46:59 PST
Autoland Patchset:
	Patches: 598891
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=4e376d1624f1
Try run started, revision 4e376d1624f1. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=4e376d1624f1
Comment 20 Mozilla RelEng Bot 2012-02-21 18:03:49 PST
Try run for 4e376d1624f1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=4e376d1624f1
Results (out of 214 total builds):
    success: 176
    warnings: 24
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-4e376d1624f1
Comment 22 Richard Newman [:rnewman] 2012-02-23 18:51:31 PST
https://hg.mozilla.org/mozilla-central/rev/c5d42c74c357

Note You need to log in before you can comment on or make changes to this bug.