Closed Bug 407221 Opened 12 years ago Closed 8 years ago

Change l10n notes in places.properties

Categories

(Firefox :: Address Bar, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 13

People

(Reporter: atopal, Assigned: capella)

References

()

Details

Attachments

(1 file, 5 obsolete files)

The notes for localizers in places.properties from bug 406355 are unfortunately not of much help, another wording should be used.
Perhaps something like: "Used to describe the location bar autocomplete icons for users with screen readers"? Is that clearer, Abdulkadir?
Although perhaps that's not entirely accurate, since the descriptions might not necessarily map to icons in the popup. Seth might be able to come up with something better.
Would definitely be better, it's not so important that the description is 100% accurate, in this case it would be enough to just know, whether the labels are used as nouns or verbs.
Whiteboard: [good first bug]
Attached patch Change notes in properties file (obsolete) — Splinter Review
I'm reviewing the [Good first bugs] and wonder if this old item is resolvable with the (simple) attached patch ...
Comment on attachment 595536 [details] [diff] [review]
Change notes in properties file

Review of attachment 595536 [details] [diff] [review]:
-----------------------------------------------------------------

based on the above feedback, I'd probably do "Noun used to describe..."

Btw, tentatively asking feedback to Kadir
Attachment #595536 - Flags: feedback?(a.topal)
So, maybe "Noun used to describe the location bar autocomplete result type to users with screen readers"
Attached patch Bug fix with "Noun" wording... (obsolete) — Splinter Review
Bug fix with "Noun" wording...
Attachment #595536 - Attachment is obsolete: true
Attachment #596023 - Flags: review?(a.topal)
Attachment #595536 - Flags: feedback?(a.topal)
Attachment #596023 - Attachment is obsolete: true
Attachment #596615 - Flags: review?(a.topal)
Attachment #596023 - Flags: review?(a.topal)
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
If you don't get an answer in a couple days, feel free to flag me for review.
mak: thanks for the fallback, will wait for a few
Attached patch Small patch (obsolete) — Splinter Review
As per previous comment ...
Attachment #596615 - Attachment is obsolete: true
Attachment #598539 - Flags: review?(mak77)
Attachment #596615 - Flags: review?(a.topal)
Comment on attachment 598539 [details] [diff] [review]
Small patch

Review of attachment 598539 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/places/places.properties
@@ +79,4 @@
>  # See createResultLabel() in urlbarBindings.xml 
>  tagResultLabel=Tag
>  # LOCALIZATION NOTE (bookmarkResultLabel) :
> +# Noun used to describe the location bar autocomplete result type to users with screen readers

I'd just ask you to go on a new line so that the text is limited to 80 chars
Attached patch Small patch v2 (obsolete) — Splinter Review
Two lines ... <80 chars
Attachment #598539 - Attachment is obsolete: true
Attachment #598882 - Flags: review?(mak77)
Attachment #598539 - Flags: review?(mak77)
Comment on attachment 598882 [details] [diff] [review]
Small patch v2

Review of attachment 598882 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/places/places.properties
@@ +80,5 @@
>  # See createResultLabel() in urlbarBindings.xml 
>  tagResultLabel=Tag
>  # LOCALIZATION NOTE (bookmarkResultLabel) :
> +# Noun used to describe the location bar
> +# Autocomplete result type to users with screen readers

why did Autocomplete become uppercase? maybe it's just your text editor's fault, please fix it.

I'd probably break after type, but that's not that much important.
Attachment #598882 - Flags: review?(mak77) → review+
Attached patch Small patch v3Splinter Review
I'll get there yet!  :-)
Attachment #598882 - Attachment is obsolete: true
Attachment #598891 - Flags: review?(mak77)
Comment on attachment 598891 [details] [diff] [review]
Small patch v3

yes, you did it!
Attachment #598891 - Flags: review?(mak77) → review+
Whiteboard: [good first bug] → [good first bug][autoland]
Whiteboard: [good first bug][autoland] → [autoland]
autoland currently only works on try, is that your purpose?
Yes, but it doesn't actually seem to be working. I realize that TRYing a comment change is trivial, but I was testing out the functionality for future.

(I really need to pursue my L1 access).
Whiteboard: [autoland] → [autoland-in-queue]
Autoland Patchset:
	Patches: 598891
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=4e376d1624f1
Try run started, revision 4e376d1624f1. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=4e376d1624f1
Keywords: checkin-needed
Try run for 4e376d1624f1 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=4e376d1624f1
Results (out of 214 total builds):
    success: 176
    warnings: 24
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-4e376d1624f1
Whiteboard: [autoland-in-queue]
https://hg.mozilla.org/mozilla-central/rev/c5d42c74c357
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.