Closed
Bug 407297
Opened 18 years ago
Closed 18 years ago
nsIHTMLToTextSink should use nsStringGlue.h instead of nsString.h
Categories
(Core :: DOM: Serializers, defect)
Core
DOM: Serializers
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: prasad, Assigned: prasad)
References
Details
Attachments
(1 file)
|
930 bytes,
patch
|
benjamin
:
review+
bzbarsky
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
nsIHTMLToTextSink.h is used in a couple of places in the mailnews code (being migrated to frozen linkage). It should probably include nsStringGlue.h and not nsString.h
It is a pretty straight forward change and the patch is attached.
Attachment #292018 -
Flags: review?(bzbarsky)
|
Assignee | |
Updated•18 years ago
|
Attachment #292018 -
Attachment description: Changes nsString.h to nsStringGlue.h → Changes nsString.h to nsStringGlue.h in nsIHTMLToTextSink
|
|
||
Comment 1•18 years ago
|
||
Comment on attachment 292018 [details] [diff] [review]
Changes nsString.h to nsStringGlue.h in nsIHTMLToTextSink
I'm not up on our string glue stuff enough to review this. Try Benjamin?
Attachment #292018 -
Flags: review?(bzbarsky) → review?(benjamin)
|
||
Updated•18 years ago
|
Attachment #292018 -
Flags: review?(benjamin) → review+
|
|
||
Comment 2•18 years ago
|
||
Comment on attachment 292018 [details] [diff] [review]
Changes nsString.h to nsStringGlue.h in nsIHTMLToTextSink
This should hopefully be a safe change that allows mailnews to move forward.
Attachment #292018 -
Flags: superreview+
Attachment #292018 -
Flags: approval1.9?
|
|
||
Updated•18 years ago
|
Attachment #292018 -
Flags: approval1.9? → approval1.9+
|
||
Updated•18 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•18 years ago
|
||
Checking in content/base/public/nsIHTMLToTextSink.h;
/cvsroot/mozilla/content/base/public/nsIHTMLToTextSink.h,v <-- nsIHTMLToTextSink.h
new revision: 1.8; previous revision: 1.7
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
||
Updated•18 years ago
|
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9 M11
You need to log in
before you can comment on or make changes to this bug.
Description
•