407352 - MakeSpaceTextRun should short-circuit zero-sized fonts [ASSERTION: throwing away our good metrics]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mats Palmgren (inactive)]

MakeSpaceTextRun should short-circuit zero-sized fonts.

Follow-up from bug 404112 comment 29 / bug 406635 comment 8

Also occurs on  http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox

Comment 1

[Mats Palmgren (inactive)]

Attachment: stack

Comment 2

[Mats Palmgren (inactive)]

Attachment: Like so?

Comment 3

[Karl Tomlinson (:karlt)]

+        NS_ASSERTION(mSpaceGlyph != 0, "GetSpaceGlyph() called with zero-sized font?");

Interesting:  the only fonts I can find (on Mac, Vista, XP, Linux) without a space glyph are

Vista: "Bookshelf Symbol 7" BSSYM7.TTF
XP: "Marlett" marlett.ttf
Linux: "Sinaloa" freefonts/capri.pfb,
       "Sharktooth" sharefonts/sharktoo.pfb

These fonts would fire the assert but I doubt they are used much on the web.

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Yeah, I think we should test the font size instead, that maps more directly
to what we want to detect.  (only change is the assertion)

Comment 5

[Mats Palmgren (inactive)]

mozilla/gfx/thebes/public/gfxPangoFonts.h 	1.58
mozilla/gfx/thebes/src/gfxFont.cpp 	1.80 

-> FIXED