407402 - Bugzilla should die if data/params doesn't exist, but it isn't dying

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Max Kanat-Alexander]

Lots of people report that they get strange errors like " Can't locate Bugzilla/Auth/Login/.pn in @INC", which really means Bugzilla couldn't read data/params.

Our current param-reading code looks like this:

        $s->rdo("$datadir/params");
        die "Error reading $datadir/params: $!" if $!;
        die "Error evaluating $datadir/params: $@" if $@;

So that *looks* like it ought to die when it can't read the file, but it isn't dying.

Comment 1

[Max Kanat-Alexander]

Ah, okay. I figured out the problem. If the file doesn't exist, then it doesn't die. If it's just an honest permissions failure, it actually does die. So we need to also check that the file exists.

Comment 2

[Max Kanat-Alexander]

Ah, this is because installation calls Bugzilla->params many times when the file doesn't exist. However, if we're in a CGI, we should die if params doesn't exist.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, this is pretty straightforward. I think we can take it on the branch, too. There are no CGIs that can be validly called when data/params doesn't exist.

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 292140 [details] [diff] [review]
v1

This seems to do what it says.  If I nuke my data/params file I get a not-so-pretty (but functional) error message.

How concerned are we about $datadir exposing file paths?  It seems to give a full pathname if you're in mod_perl.

Comment 5

[Max Kanat-Alexander]

Thanks for the review! :-) We're not concerned about exposing file paths. I don't perceive a serious security issue there, unless people are interested in security by obscurity.

Comment 6

[Max Kanat-Alexander]

tip:

Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.73; previous revision: 1.72
done

3.0:

Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.70.2.1; previous revision: 1.70
done