407412 - create a vm that is setup to build mozillabuild

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[[e-mail] (:bhearsum)]

Attachment: mozillabuild updates to make it work on the mozillabuild-builder vm

This required some updates to MozillaBuild. Detailed set-up instructions are in a commented atop packageit.py. A couple bugfixes have been included with this.

Comment 1

[(not currently active) Ted Mielczarek]

-# Make an installer
+ Make an installer

Looks like you lost a comment there, fwiw.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: make 'Make an installer' a comment

thanks for catching that Ted

Comment 3

[[e-mail] (:bhearsum)]

Attachment: [checked in] additional fix to make cvs install to the right location

Comment 4

[Benjamin Smedberg]

Comment on attachment 292390 [details] [diff] [review]
[checked in] additional fix to make cvs install to the right location

Wow, is that why the upgraded "cvs" never made it into MB 1.1 :-(

Thank you so much for doing this!

Comment 5

[[e-mail] (:bhearsum)]

Checking in libiconv-build.patch;
/cvsroot/mozilla/tools/build-environment/win32/libiconv-build.patch,v  <--  libiconv-build.patch
new revision: 1.2; previous revision: 1.1
done
Checking in packageit-msys.sh;
/cvsroot/mozilla/tools/build-environment/win32/packageit-msys.sh,v  <--  packageit-msys.sh
new revision: 1.4; previous revision: 1.3
done
Checking in packageit.py;
/cvsroot/mozilla/tools/build-environment/win32/packageit.py,v  <--  packageit.py
new revision: 1.6; previous revision: 1.5
done


The VM is setup as mozillabuild-builder.build.mozilla.org. Ted and I both have the username/password if anyone else needs it.

Comment 6

[[e-mail] (:bhearsum)]

This patch broke DLL rebasing. Patch to fix that coming soon..

Comment 7

[[e-mail] (:bhearsum)]

Attachment: make sure DLLs get rebased

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 292638 [details] [diff] [review]
make sure DLLs get rebased

-find "${MSYS_STAGEDIR}/mozilla-build/lib" -name "*.dll" | \
+find "${MSYS_STAGEDIR}/mozilla-build" -name "*.dll" | \
+  grep -v "libW11.dll" | \
   xargs rebase -d -b 60000000

Had to make this change to get things working with this patch.  It just skips rebasing libW11.dll.  I haven't tried a full build with this environment, so we may need to skip any other DLLs that fail rebasing, I think rebase breaks them.

Comment 9

[[e-mail] (:bhearsum)]

We also need to except sqlite3.dll, tclpip84.dll, and any msvs DLLs hanging around there.

Comment 10

[[e-mail] (:bhearsum)]

Attachment: except some DLLs from rebasing

This patch excepts the DLLs in the above comments. In the original patch I had a try/catch block around packageit-msys.sh. Now that rebase should not fail (and if it does, it should be a legitimate failure), that's not needed.

Comment 11

[(not currently active) Ted Mielczarek]

Attachment: fix rebasing, seriously

This fixes all the rebasing issues for me.  It rebases all the MSYS DLLs, then specifically rebases msys-1.0.dll to a location slightly above the rest.  It's not pretty, but it works.

Comment 12

[[e-mail] (:bhearsum)]

Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild

Comment 13

[Benjamin Smedberg]

Comment on attachment 293929 [details] [diff] [review]
fix rebasing, seriously

You could probably use "find -name "*.dll" -a -not -name "libW11.dll" but the grep probably works just as well.

Comment 14

[(not currently active) Ted Mielczarek]

Checked in the last patch.