407424 - undo delete in places organizer changes sort order

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Eric Schwartz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120704 Minefield/3.0b2pre

When I delete a number of bookmarks in the Places Organizer, and then change my mind and hit Ctrl-Z to undo, they come back apparently sorted in descending order on the URL field.

Reproducible: Always

Steps to Reproduce:
1. Create the following bookmarks in a new folder in the Places Organizer:

Name     | URL
---------|-------------
Death    | http://www.a.net/
Potatoes | http://www.b.net/
Cow      | http://www.c.net/
Separator

2. Select them all, and hit the Delete button.
3. Then hit Ctrl-Z to undo the delete.

Now they should be ordered

Separator
Cow      | http://www.c.net/
Potatoes | http://www.b.net/
Death    | http://www.a.net/

Actual Results:  
Bookmarks are re-ordered on undo.

Expected Results:  
Bookmarks should retain their order when the delete is undone.

I like cookies, but I like pie better.

Comment 1

[Eric Schwartz]

Note: Carsten Book tried this on a mac, and it apparently worked there, so this may be a platform-specific bug.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120807 Minefield/3.0b2pre

The deleted items appear to be restored in reverse order.

Comment 3

[Ria Klaassen (not reading all bugmail)]

Regression range for this is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1184367360&maxdate=1184372879
with several bugs in it fixed in one.
No idea if this is something that should be blocked Firefox 3.

Comment 4

[Ria Klaassen (not reading all bugmail)]

I don't think so, so I leave requesting this to someone else.

Comment 5

[Tracy Walker [:tracy]]

-add a few bookmarks to the default set on the Toolbar.  
-Open Library and delete everything in the Bookmarks Toolbar folder
-Organize > Undo

the bookmarks I added in first step on now on left of Toolbar followed by Getting Started, Smart Bookmarks and Latest Headlines.

No loss of data but annoying.  I'd set as wanted, but don't have that right, so nominating blocking for triagers to sort out.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

This will not block the final release of Firefox 3. Any patch will need unit tests in order to be approved.

Comment 7

[Marco Bonardo [:mak]]

should have been fixed in bug 430442, it's wfm actually
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081123 Minefield/3.1b2pre

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv