407449 - After an unsuccessful drag&drop action multiple folders/bookmarks can be highlighted in the Organizer

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007120504 Minefield/3.0b2pre

Steps to reproduce:

* Open Bookmarks Organizer
* Try to drag&drop a folder within the left pane
* Click on different folders

Each of the folders clicked get highlighted but it's not removed. You have to move the mouse over the highlighted folders to undo the highlight.

After discussion on IRC it seems to be depend on bug 405198.

I cannot reproduce this issue on Windows. An OS X only issue?

Comment 1

[Asaf Romano (gone)]

I've seen this on trunk for months, mac only.

Comment 2

[Asaf Romano (gone)]

This is a core bug (very likely a regression from the thread manager landing), back to nobody`

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Asaf do you have a bug number for the thread manager landing? I could run a regression test.

Comment 4

[Asaf Romano (gone)]

Bug 326273.

I'm pretty sure places was turned off back then, so it would very hard to measure. :-/

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It doesn't only happen for folders inside the left pane. Even bookmarks on the right pane are affected.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)
> Bug 326273.
> 
> I'm pretty sure places was turned off back then, so it would very hard to
> measure. :-/

Adding Darin who did the work on bug 326273. 

Comment 7

[Asaf Romano (gone)]

Attachment: patch

This fixes it for me.

[00:19]	<Mano>	cbarrett: do you know if http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp#684 is still correct?
[00:19]	<Mano>	cbarrett: it's probably one of the reasons tree's d&d is kinda broken on mac trunk
[00:23]	<cbarrett>	Mano: Yeah, it's an OS 9 thing.
[00:23]	<cbarrett>	https://bugzilla.mozilla.org/show_bug.cgi?id=121336#c38
[00:23]	<firebot>	cbarrett: Bug 121336 nor, --, mozilla0.9.9, [e-mail], VERI FIXED, sometimes selection in threadpane (and folderpane) not cleared when selecting a new message
[00:23]	<cbarrett>	kill it!!
[00:23]	<cbarrett>	Kill it with fire!!
[00:23]	<Mano>	cbarrett: er, this was in a #ifdef XP_MACOSX
[00:23]	<cbarrett>	Mano: Read the comment I linked :\
[00:24]	<cbarrett>	Mano: the ifdef got upgraded at some point.
[00:24]	<cbarrett>	ah
[00:24]	<cbarrett>	it was originally +#if defined(XP_MAC) || defined(XP_MACOSX)
[00:24]	<cbarrett>	For no real reason
[00:24]	<cbarrett>	the event loop can still spin on OS X during a drag.

Comment 8

[Neil Deakin]

Comment on attachment 294383 [details] [diff] [review]
patch

Seems OK. The scrolling part can't really be tested due to the thread issue.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It also happens with trunk builds of Thunderbird. So which is the best component to move this bug in? Something like Core/Layout:...?

Comment 10

[Asaf Romano (gone)]

moozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp 1.346

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008010504 Minefield/3.0b3pre

It also fixes the same behavior for Thunderbird trunk builds.

Moving over to Core:Layout. No idea which subcomponent is the best.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Reasking for blocking-flag due to product change.