407477 - Use stock icons in the XUL open file dialog

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[sikon]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9b2pre) Gecko/2007120814 Firefox/3.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.9b2pre) Gecko/2007120814 Firefox/3.0b2pre

This bug is about the dialog that is used if ui.allow_platform_file_picker is set to false.

Reproducible: Always

Steps to Reproduce:
1. In about:config, set ui.allow_platform_file_picker to false.
2. Press Ctrl-O or select File -> Open file.
Actual Results:  
Winstripe icons are used for folders and the "Up" and "Home" buttons.

Expected Results:  
Stock icons are used for folders (like in the bookmark manager and FTP UI) and for the "Up" and "Home" buttons.

Comment 1

[sikon]

Attachment: Patch

Adding a patch. It replaces all icons except for the new folder one, which isn't among the stock icons. I guess the Tango team should add this icon to their todo list.

The filepicker.css file is taken from Winstripe and modified.

Comment 2

[Michael Monreal [:micmon]]

There is no folder-new in the icon inventory for Firefox 3. Maybe FF3 is meant to always use the native file picker?

Comment 3

[sikon]

In this case, the XUL filepicker dialog and the ui.allow_platform_file_picker should be removed from the code.

Comment 4

[Michael Monreal [:micmon]]

I really don't know what the plan is, but I wonder if there is any reason to keep supporting the old dialog. The native GTK one is the default for some time and the minimum GTK+ requirement was upped to 2.10, so that the new dialog is now available on every build.

If the old dialog will be kept, I agree it should be properly themed. The "folder-new" is a problem though: folder-new is not a gtk-stock icon, it is only available in fdo compliant themes. So we would need to ship a version with FF3, which would then look different with the themed folder icons we use in other places for most users.

Comment 5

[Reed Loden [:reed]]

RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker.css,v
done
Checking in toolkit/themes/gnomestripe/global/filepicker.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/filepicker.css,v  <--  filepicker.css
initial revision: 1.1
done
Checking in toolkit/themes/gnomestripe/global/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/jar.mn,v  <--  jar.mn
new revision: 1.21; previous revision: 1.20
done

Comment 6

[Michael Monreal [:micmon]]

What patch was checked in here?

Comment 7

[Reed Loden [:reed]]

(In reply to comment #6)
> What patch was checked in here?

The only one in the bug...

Comment 8

[Michael Monreal [:micmon]]

So the folder-new icon is still the old one?

Comment 9

[sikon]

Yes.

Comment 10

[Michael Monreal [:micmon]]

So after this comment from IRC:

<Ryan> we're keeping the dialog... It's one of the top customizations done by KDE users and KDE shipping distros

I kind of understand. Well, in that case I think any tango folder-new would be nicer to have instead of old icon, even if it does not match the themed gtk-directory icon very closely.

Are you ok with shipping folder-new icon that matches the tango icons in the default GNOME theme?

Comment 11

[Michael Monreal [:micmon]]

Btw, is "go one level up" also needed? I just found it in the icon sheet that is currently shipped.